checkpatch.pl stalls on net/decnet/dn_fib.c

checkpatch.pl stalls on net/decnet/dn_fib.c

[John Daiker]

Andy,

Was running checkpatch.pl on the entire tree today (because my disk 
loves to get thrashed like that...)  Found what seems to be a stall/hang 
while running checkpatch.  I know nothing of the internal workings of 
checkpatch.pl, but hope that you're able to sniff this one out!

./scripts/checkpatch.pl --file ./net/decnet/dn_fib.c  --debug values=9 
types=9 possible=9 attr=9

--snip--
51 > . #define endfor_fib_info() }
51 > EEEEEEEEEEEEEEEEEEEEEEEEENNNEE
51 >  _____________________________


<E> <E> <_>WS(
)
52 > .
52 > EEE
52 >  __
  #define for_nexthops(fi) { int nhsel; const struct dn_fib_nh *nh;\

<E> <E> <_>WS( )
<E> <E> <_>DEFINE(#define for_nexthops,()
<EE> <E> <N>PAREN('(')
<EEN> <N> <_>IDENT(fi)
<EEN> <V> <_>PAREN(')') -> N
<EE> <N> <_>WS( )
<EE> <N> <_>END({)
<EE> <E> <_>WS( )
<EE> <E> <_>DECLARE(int )
<EE> <T> <_>IDENT(nhsel)
<EE> <V> <_>END(;)
<EE> <E> <_>WS( )
<EE> <E> <_>DECLARE(const struct dn_fib_nh *)
<EE> <T> <_>IDENT(nh)
<EE> <V> <_>END(;)
<EE> <E> <_>PRECONT(\
)
53 > . #define for_nexthops(fi) { int nhsel; const struct dn_fib_nh *nh;\
53 > EEEEEEEEEEEEEEEEEEEEEENVVNNEETTTTVVVVVEETTTTTTTTTTTTTTTTTTTTTTTTVVEEE
53 >  ____________________________________________________________________
HANGHANGHANGHANG
--snip--

Hope this helps!  Let me know if I can assist in debugging at all.

Thanks,
John Daiker

Re: checkpatch.pl stalls on net/decnet/dn_fib.c

[Andy Whitcroft]

On Thu, Feb 19, 2009 at 03:05:50PM -0800, John Daiker wrote:
> Andy,
>
> Was running checkpatch.pl on the entire tree today (because my disk  
> loves to get thrashed like that...)  Found what seems to be a stall/hang  
> while running checkpatch.  I know nothing of the internal workings of  
> checkpatch.pl, but hope that you're able to sniff this one out!
>
> ./scripts/checkpatch.pl --file ./net/decnet/dn_fib.c  --debug values=9  
> types=9 possible=9 attr=9

Hmmm, yes thats broken indeed.  Will have a look at it.

-apw

Re: checkpatch.pl stalls on net/decnet/dn_fib.c

[Andy Whitcroft]

On Mon, Feb 23, 2009 at 02:53:29PM +0000, Andy Whitcroft wrote:
> On Thu, Feb 19, 2009 at 03:05:50PM -0800, John Daiker wrote:
> > Andy,
> >
> > Was running checkpatch.pl on the entire tree today (because my disk  
> > loves to get thrashed like that...)  Found what seems to be a stall/hang  
> > while running checkpatch.  I know nothing of the internal workings of  
> > checkpatch.pl, but hope that you're able to sniff this one out!
> >
> > ./scripts/checkpatch.pl --file ./net/decnet/dn_fib.c  --debug values=9  
> > types=9 possible=9 attr=9
> 
> Hmmm, yes thats broken indeed.  Will have a look at it.

Ok, think I have this one sorted.  Could you test with the version of
checkpatch at this URL:

  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

Thanks for the report. 

-apw

Re: checkpatch.pl stalls on net/decnet/dn_fib.c

[John Daiker]

On 02/23/2009 07:15 AM, Andy Whitcroft wrote:
> On Mon, Feb 23, 2009 at 02:53:29PM +0000, Andy Whitcroft wrote:
>    
>> On Thu, Feb 19, 2009 at 03:05:50PM -0800, John Daiker wrote:
>>      
>>> Andy,
>>>
>>> Was running checkpatch.pl on the entire tree today (because my disk
>>> loves to get thrashed like that...)  Found what seems to be a stall/hang
>>> while running checkpatch.  I know nothing of the internal workings of
>>> checkpatch.pl, but hope that you're able to sniff this one out!
>>>
>>> ./scripts/checkpatch.pl --file ./net/decnet/dn_fib.c  --debug values=9
>>> types=9 possible=9 attr=9
>>>        
>> Hmmm, yes thats broken indeed.  Will have a look at it.
>>      
>
> Ok, think I have this one sorted.  Could you test with the version of
> checkpatch at this URL:
>
>    http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
>
> Thanks for the report.
>
> -apw
>    
Andy,

That did the trick.  Thanks!

(Sorry if this was double-posted... user error the first time)

John