From: Thomas Backlund <tmb@mandriva.org>
To: linux-kernel@vger.kernel.org
Cc: Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, stable@kernel.org,
Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Michael Krufky <mkrufky@linuxtv.org>,
Chuck Ebbert <cebbert@redhat.com>,
Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk,
David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [patch 03/36] Fix Intel IOMMU write-buffer flushing
Date: Fri, 20 Feb 2009 01:59:48 +0200 [thread overview]
Message-ID: <499DF274.8040702@mandriva.org> (raw)
In-Reply-To: <499C9394.5030704@mandriva.org>
Thomas Backlund skrev:
> This patch is broken compared to what's in:
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ca77fde8e62cecb2c0769052228d15b901367af8
>
>
> attached patch fixes it
>
As no-one responded yet...
I forgot to tell how to reproduce it:
on x86_64:
make defconfig
make
and you will end up with:
[thomas@tmb linux-2.6.27.19-rc1]$ LC_ALL=C make
CHK include/linux/version.h
CHK include/linux/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/linux/compile.h
CC drivers/pci/intel-iommu.o
drivers/pci/intel-iommu.c: In function 'iommu_flush_write_buffer':
drivers/pci/intel-iommu.c:530: error: 'rwbf_quirk' undeclared (first use
in this function)
drivers/pci/intel-iommu.c:530: error: (Each undeclared identifier is
reported only once
drivers/pci/intel-iommu.c:530: error: for each function it appears in.)
make[2]: *** [drivers/pci/intel-iommu.o] Error 1
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2
[thomas@tmb linux-2.6.27.19-rc1]$
This happends because 'rwbf_quirk' is declared after it's first use.
The upstream git has 'rwbf_quirk' declared before any use of it.
That's what my patch fixes, by simply moving
static int rwbf_quirk = 0;
to the beginning of the file...
Hopefully this helps.
--
Thomas
next prev parent reply other threads:[~2009-02-20 0:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090218222447.432108614@mini.kroah.org>
2009-02-18 22:28 ` [patch 00/36] 2.6.27.19-stable review Greg KH
2009-02-18 22:28 ` [patch 01/36] pid: implement ns_of_pid Greg KH
2009-02-18 22:28 ` [patch 02/36] mqueue: fix si_pid value in mqueue do_notify() Greg KH
2009-02-18 22:29 ` [patch 03/36] Fix Intel IOMMU write-buffer flushing Greg KH
2009-02-18 23:02 ` Thomas Backlund
2009-02-19 23:59 ` Thomas Backlund [this message]
2009-02-20 3:35 ` Greg KH
2009-02-20 13:57 ` Thomas Backlund
2009-02-21 10:34 ` David Woodhouse
2009-02-18 22:29 ` [patch 04/36] powerpc/vsx: Fix VSX alignment handler for regs 32-63 Greg KH
2009-02-18 22:29 ` [patch 05/36] sata_nv: give up hardreset on nf2 Greg KH
2009-02-18 22:29 ` [patch 06/36] 3c505: do not set pcb->data.raw beyond its size Greg KH
2009-02-18 22:29 ` [patch 07/36] Add support for VT6415 PCIE PATA IDE Host Controller Greg KH
2009-02-18 22:29 ` [patch 08/36] Bluetooth: Fix TX error path in btsdio driver Greg KH
2009-02-18 22:29 ` [patch 09/36] btsdio: free sk_buff with kfree_skb Greg KH
2009-02-18 22:29 ` [patch 10/36] ext2/xip: refuse to change xip flag during remount with busy inodes Greg KH
2009-02-18 22:29 ` [patch 11/36] SCSI: libiscsi: fix iscsi pool leak Greg KH
2009-02-18 22:29 ` [patch 12/36] x86/cpa: make sure cpa is safe to call in lazy mmu mode Greg KH
2009-02-18 22:29 ` [patch 13/36] ext4: Add support for non-native signed/unsigned htree hash algorithms Greg KH
2009-02-18 22:29 ` [patch 14/36] ext4: tone down ext4_da_writepages warnings Greg KH
2009-02-18 22:29 ` [patch 15/36] ext4: Fix the delalloc writepages to allocate blocks at the right offset Greg KH
2009-02-18 22:29 ` [patch 16/36] ext4: avoid ext4_error when mounting a fs with a single bg Greg KH
2009-02-18 22:29 ` [patch 17/36] ext4: Widen type of ext4_sb_info.s_mb_maxs[] Greg KH
2009-02-18 22:29 ` [patch 18/36] jbd2: Add barrier not supported test to journal_wait_on_commit_record Greg KH
2009-02-18 22:29 ` [patch 19/36] ext4: Dont overwrite allocation_context ac_status Greg KH
2009-02-18 22:29 ` [patch 20/36] ext4: Add blocks added during resize to bitmap Greg KH
2009-02-18 22:29 ` [patch 21/36] ext4: Use EXT4_GROUP_INFO_NEED_INIT_BIT during resize Greg KH
2009-02-18 22:29 ` [patch 22/36] ext4: cleanup mballoc header files Greg KH
2009-02-18 22:29 ` [patch 23/36] ext4: Use an rbtree for tracking blocks freed during transaction Greg KH
2009-02-18 22:29 ` [patch 24/36] ext4: dont use blocks freed but not yet committed in buddy cache init Greg KH
2009-02-18 22:29 ` [patch 25/36] ext4: Fix race between read_block_bitmap() and mark_diskspace_used() Greg KH
2009-02-18 22:29 ` [patch 26/36] ext4: Fix the race between read_inode_bitmap() and ext4_new_inode() Greg KH
2009-02-18 22:29 ` [patch 27/36] jbd2: Add BH_JBDPrivateStart Greg KH
2009-02-18 22:29 ` [patch 28/36] ext4: Use new buffer_head flag to check uninit group bitmaps initialization Greg KH
2009-02-18 22:29 ` [patch 29/36] ext4: mark the blocks/inode bitmap beyond end of group as used Greg KH
2009-02-18 22:29 ` [patch 30/36] ext4: Dont allow new groups to be added during block allocation Greg KH
2009-02-18 22:29 ` [patch 31/36] ext4: Init the complete page while building buddy cache Greg KH
2009-02-18 22:29 ` [patch 32/36] ext4: Add sanity checks for the superblock before mounting the filesystem Greg KH
2009-02-18 22:29 ` [patch 33/36] ext4: only use i_size_high for regular files Greg KH
2009-02-18 22:29 ` [patch 34/36] ext4: Add sanity check to make_indexed_dir Greg KH
2009-02-18 22:30 ` [patch 35/36] jbd2: On a __journal_expect() assertion failure printk "JBD2", not "EXT3-fs" Greg KH
2009-02-18 22:30 ` [patch 36/36] ext4: Initialize the new group descriptor when resizing the filesystem Greg KH
2009-02-19 20:48 ` [patch 00/36] 2.6.27.19-stable review Jörg-Volker Peetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499DF274.8040702@mandriva.org \
--to=tmb@mandriva.org \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cavokz@gmail.com \
--cc=cebbert@redhat.com \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=eteo@redhat.com \
--cc=gregkh@suse.de \
--cc=jake@lwn.net \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=rbranco@la.checkpoint.com \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).