Re: [PATCH] pciehp: Handle interrupts that happen during initialization.

Jesse Barnes
2009-02-24T17:08:57Z

On Monday, February 23, 2009 3:08:44 am Eric W. Biederman wrote:
> Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> writes:
> > Ok, I understood what is happening. Could you try the following patch?
> > It is currently in Jesse's linux-next.
> >
> > http://marc.info/?l=linux-pci&m=123364118418484&w=2
> >
> > BTW, I don't think surprise removal is well tested.
>
> That patch should guarantee that we don't loop forever, and if we are
> going to loop that looks like a reasonable way to handle it.
>
> When I start working on what is the most maintainable way to implement
> merge my hotplug driver work I will come back and test this.
>
> At the moment it appears that it will at least suffer from detecting a
> presence change event with a device showing up. Before pci structure
> for the device is removed. I seem to recall some dead locks on the
> pciehp work queue hotunplugging a hotplug driver as well.

Ah looks like Kenji-san wants this one pushed; so unless I hear otherwise I'll
queue it up in my for-linus branch for Linus to pull tomorrow or so.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center