Re: [PATCH] pciehp: Handle interrupts that happen during initialization.

Eric W. Biederman
2009-02-23T11:17:19Z

ebiederm@xmission.com (Eric W. Biederman) writes:

> Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> writes:
>
>> In the current pciehp implementation, minimum resources enough to
>> enable devices under the bridge are assigned when P2P bridge is
>> hot-added. My concern is that enough resources are NOT assigned to
>> the bridge if an additional slot is empty. As a result, hot-add
>> adapter card on the additional slot won't work because of resource
>> shortage.
>
> It is a good concern. Right now I know I won't need a bus number
> but you are quite right the mmio and iospace may be a problem.
>
> My preliminary test case doesn't cover that so I will look and
> confirm it is a problem I need to address.

Tested. I do have a problem with not assigning resources to new
bridges.

My plan to handle this currently is to do what the pci code does for
cardbus without resources. To give them a fixed sized resource
assignment without looking downstream from the bridge. The code
looks simple, and we have existing practice so it should not be too
bad to deal with.

Eric