* [PATCH] IA64: cast has a higher precedence than '?'
@ 2009-02-20 12:05 Roel Kluin
2009-02-20 12:37 ` Ingo Molnar
2009-02-20 12:37 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Roel Kluin @ 2009-02-20 12:05 UTC (permalink / raw)
To: mingo; +Cc: lkml, Andrew Morton
because of the ?: this is not strictly necessary, but I think the added
parentheses are nice here.
--------------------------->8-------------8<------------------------------
A cast has a higher precedence than '?'
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h
index d82f39b..b8a1933 100644
--- a/arch/x86/include/asm/syscall.h
+++ b/arch/x86/include/asm/syscall.h
@@ -61,7 +61,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
struct pt_regs *regs,
int error, long val)
{
- regs->ax = (long) error ?: val;
+ regs->ax = (long) (error ?: val);
}
#ifdef CONFIG_X86_32
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] IA64: cast has a higher precedence than '?'
2009-02-20 12:05 [PATCH] IA64: cast has a higher precedence than '?' Roel Kluin
@ 2009-02-20 12:37 ` Ingo Molnar
2009-02-20 12:37 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-02-20 12:37 UTC (permalink / raw)
To: Roel Kluin; +Cc: mingo, lkml, Andrew Morton
* Roel Kluin <roel.kluin@gmail.com> wrote:
> because of the ?: this is not strictly necessary, but I think the added
> parentheses are nice here.
>
> --------------------------->8-------------8<------------------------------
> A cast has a higher precedence than '?'
> @@ -61,7 +61,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
> struct pt_regs *regs,
> int error, long val)
> {
> - regs->ax = (long) error ?: val;
> + regs->ax = (long) (error ?: val);
it doesnt matter, does it? the 32-bit entity here is 'error', so
casting it to 64-bit long is just as fine as casting the end
result to long. In fact this should be the best:
regs->ax = error ?: val;
as the 32-bit 'error' will be extended to 64 bits anyway.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] IA64: cast has a higher precedence than '?'
2009-02-20 12:05 [PATCH] IA64: cast has a higher precedence than '?' Roel Kluin
2009-02-20 12:37 ` Ingo Molnar
@ 2009-02-20 12:37 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-02-20 12:37 UTC (permalink / raw)
To: Roel Kluin; +Cc: mingo, lkml, Andrew Morton
> --- a/arch/x86/include/asm/syscall.h
> +++ b/arch/x86/include/asm/syscall.h
btw., the subject line is wrong - this is not an ia64 patch but
an x86 patch.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-20 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-20 12:05 [PATCH] IA64: cast has a higher precedence than '?' Roel Kluin
2009-02-20 12:37 ` Ingo Molnar
2009-02-20 12:37 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox