Re: mmotm 2009-02-20-15-52 uploaded (via-sdmmc)

Re: mmotm 2009-02-20-15-52 uploaded (via-sdmmc)

[Randy Dunlap]

akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2009-02-20-15-52 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> and will soon be available at
> 
>    git://git.zen-sources.org/zen/mmotm.git
> 
> It contains the following patches against 2.6.29-rc5:
> 

> via-sdmmc-via-msp-card-reader-driver-support.patch


when CONFIG_PM=n:

drivers/mmc/host/via-sdmmc.c:336: error: 'struct via_crdr_chip' has no member named 'pm_pcictrl_reg'
drivers/mmc/host/via-sdmmc.c:355: error: 'struct via_crdr_chip' has no member named 'pm_pcictrl_reg'
drivers/mmc/host/via-sdmmc.c:372: error: 'struct via_crdr_chip' has no member named 'pm_sdhc_reg'
drivers/mmc/host/via-sdmmc.c:392: error: 'struct via_crdr_chip' has no member named 'pm_sdhc_reg'

-- 
~Randy

RE: mmotm 2009-02-20-15-52 uploaded (via-sdmmc)

[JosephChan]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1491 bytes --]

Randy,

We’ve fixed this is v5 patch. Thanks.
I will send out  this patch later.


Andrew,

Any comment on this? Should I send the whole v5 patch to linux-kernel mail-list? Or just patch for this issue? Thanks.

BRs,
Joseph

> -----Original Message-----
> From: Randy Dunlap [mailto:randy.dunlap@oracle.com] 
> Sent: Saturday, February 21, 2009 12:44 PM
> To: linux-kernel@vger.kernel.org
> Cc: Andrew Morton; Joseph Chan
> Subject: Re: mmotm 2009-02-20-15-52 uploaded (via-sdmmc)
> 
> akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2009-02-20-15-52 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > and will soon be available at
> > 
> >    git://git.zen-sources.org/zen/mmotm.git
> > 
> > It contains the following patches against 2.6.29-rc5:
> > 
> 
> > via-sdmmc-via-msp-card-reader-driver-support.patch
> 
> 
> when CONFIG_PM=n:
> 
> drivers/mmc/host/via-sdmmc.c:336: error: 'struct 
> via_crdr_chip' has no member named 'pm_pcictrl_reg'
> drivers/mmc/host/via-sdmmc.c:355: error: 'struct 
> via_crdr_chip' has no member named 'pm_pcictrl_reg'
> drivers/mmc/host/via-sdmmc.c:372: error: 'struct 
> via_crdr_chip' has no member named 'pm_sdhc_reg'
> drivers/mmc/host/via-sdmmc.c:392: error: 'struct 
> via_crdr_chip' has no member named 'pm_sdhc_reg'
> 
> --
> ~Randy
> 
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: mmotm 2009-02-20-15-52 uploaded (via-sdmmc)

[Andrew Morton]

On Tue, 24 Feb 2009 11:44:35 +0800 <JosephChan@via.com.tw> wrote:

> Any comment on this? Should I send the whole v5 patch to linux-kernel mail-list? Or just patch for this issue? Thanks.

It doesn't matter a lot really.  If you send a full patch I'll turn it
into a delta so I can see what you did.  But as I'm probably the only
person who read the original patch, I'm the only one who will be
interested in seeing the delta ;)

So please do whatever is convenient.