public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: Jesper Juhl <jj@chaosbits.net>,
	linux-kernel@vger.kernel.org,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	Paul Jackson <pj@sgi.com>, Simon Derr <simon.derr@bull.net>
Subject: Re: [PATCH] Remove some pointless conditionals before kfree() in kernel/cgroup.c
Date: Mon, 23 Feb 2009 16:30:11 +0800	[thread overview]
Message-ID: <49A25E93.10708@cn.fujitsu.com> (raw)
In-Reply-To: <6599ad830902230012x170e2183q1540670d761ef80e@mail.gmail.com>

>> Reduces object file size a bit :
>>
>> Before:
>> $ size kernel/cgroup.o
>>   text    data     bss     dec     hex filename
>>  21593    7804    4924   34321    8611 kernel/cgroup.o
>> After:
>> $ size kernel/cgroup.o
>>   text    data     bss     dec     hex filename
>>  21537    7744    4924   34205    859d kernel/cgroup.o
> 
> Thanks. I'm a bit surprised that it also shrunk the data segment size
> (and in fact, by more than the text segment size). Any idea how that
> came about?
> 

A bit odd..

Here is the result on my x86_32:
   text    data     bss     dec     hex filename
  14118    1804    4960   20882    5192 kernel/cgroup.o.orig
   text    data     bss     dec     hex filename
  14114    1804    4960   20878    518e kernel/cgroup.o

And on IA64:
   text    data     bss     dec     hex filename
  42399    2712    5616   50727    c627 kernel/cgroup.o.orig
   text    data     bss     dec     hex filename
  42367    2712    5616   50695    c607 kernel/cgroup.o

No change in data segment.

  parent reply	other threads:[~2009-02-23  8:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-22 22:05 [PATCH] Remove some pointless conditionals before kfree() in kernel/cgroup.c Jesper Juhl
2009-02-23  8:12 ` Paul Menage
2009-02-23  8:17   ` Cyrill Gorcunov
2009-02-23  8:19     ` Cyrill Gorcunov
2009-02-23  8:30   ` Li Zefan [this message]
2009-02-23 21:46   ` Jesper Juhl
2009-02-23  8:32 ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A25E93.10708@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=pj@sgi.com \
    --cc=shemminger@linux-foundation.org \
    --cc=simon.derr@bull.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox