From: "H. Peter Anvin" <hpa@zytor.com>
To: Stas Sergeev <stsp@aknet.ru>
Cc: Linux kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Zachary Amsden <zach@vmware.com>,
Chuck Ebbert <76306.1226@compuserve.com>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [patch] small fix to espfix code
Date: Mon, 23 Feb 2009 10:32:48 -0800 [thread overview]
Message-ID: <49A2EBD0.2020303@zytor.com> (raw)
In-Reply-To: <49A2CB13.4080708@aknet.ru>
Stas Sergeev wrote:
>
> The bug is mostly theoretical, I can't
> really test the effect of this patch.
> So, it is completely untested.
>
It's not a bug, as the stack is aligned such that 16-bit overflow can't
happen. However, it is arguably cleaner to have addl here.
-hpa
prev parent reply other threads:[~2009-02-23 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 16:13 [patch] small fix to espfix code Stas Sergeev
2009-02-23 18:32 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A2EBD0.2020303@zytor.com \
--to=hpa@zytor.com \
--cc=76306.1226@compuserve.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stsp@aknet.ru \
--cc=x86@kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox