From: Yinghai Lu <yinghai@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Jourdan <tjourdan@interfaceconcept.com>,
linux-kernel@vger.kernel.org, Huang Ying <ying.huang@intel.com>,
Peter Jones <pjones@redhat.com>
Subject: Re: [BUG] dmi_scan_machine uses uninitialized address on x86 / EFI
Date: Tue, 24 Feb 2009 13:38:42 -0800 [thread overview]
Message-ID: <49A468E2.4040308@kernel.org> (raw)
In-Reply-To: <49A462BD.7010205@zytor.com>
H. Peter Anvin wrote:
> Thomas Jourdan wrote:
>> On x86/EFI platforms, if efi_enabled is true, the dmi_scan_machine function
>> fails, even if valid DMI table is present. In the setup_arch function,
>> efi_init is called after dmi_scan_machine. But this is efi_init which will
>> initialize the smbios address, needed by dmi_scan_machine.
>>
>> This leads to dmi_scan_machine ioremapping physical address 0, instead of
>> the address provided by the EFI system table. The following patch fixes the
>> problem.
>>
>
> Hi Thomas,
>
> What is the concrete manifestation of the bug (i.e. how critical is it?)
> We are late in the 2.6.29-rc cycle, and this patch seems to have some
> risk associated with it.
>
> Huang, Peter, Yinghai: any opinions?
>
should be ok for 2.6.29
YH
next prev parent reply other threads:[~2009-02-24 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 15:40 [BUG] dmi_scan_machine uses uninitialized address on x86 / EFI Thomas Jourdan
2009-02-24 21:12 ` H. Peter Anvin
2009-02-24 21:38 ` Yinghai Lu [this message]
2009-02-24 21:42 ` H. Peter Anvin
2009-02-24 21:44 ` Yinghai Lu
2009-02-25 12:28 ` Thomas Jourdan
2009-02-25 22:04 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A468E2.4040308@kernel.org \
--to=yinghai@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=tjourdan@interfaceconcept.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox