Re: [PATCH v2 2/4] x86: Add an option to compile with -ffunction-sections -fdata-sections

["H. Peter Anvin" <hpa@zytor.com>]

Tim Abbott wrote:
> From: Waseem Daher <wdaher@mit.edu>
> 
> This patch makes it possible to link and boot an x86 kernel with
> -ffunction-sections and -fdata-sections enabled.
> 
> Modpost currently warns whenever it sees a section with a name
> matching [.][0-9]+$ because they are often caused by section flag
> mismatch errors.  When compiling with -ffunction-sections
> -fdata-sections, gcc places various classes of local symbols in
> sections with names such as .rodata.__func__.12345, causing these
> warnings to be printed spuriously.  The simplest fix is to disable the
> warning when CONFIG_FUNCTION_DATA_SECTIONS is enabled.
> 

This is a pretty critical set of warnings, that often represent real
bugs.  I don't think it's acceptable to lose them.  However, you already
have (prior in the sequence) changed those section names to not conflict
with the automatically generated ones, so it seems to me that this
should be fixable without too much pain.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.