From: "H. Peter Anvin" <hpa@zytor.com>
To: Kyle McMartin <kyle@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Sam Ravnborg <sam@ravnborg.org>,
Jaswinder Singh Rajput <jaswinderrajput@gmail.com>,
mingo@redhat.com, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [rfc] headers_check cleanups break the whole world
Date: Tue, 24 Feb 2009 23:08:53 -0800 [thread overview]
Message-ID: <49A4EE85.5000907@zytor.com> (raw)
In-Reply-To: <20090225070511.GG6690@bombadil.infradead.org>
Kyle McMartin wrote:
>
> Yeah, sorry, I should have been clearer, libcap does stupid
> #define _LINUX_TYPES_H_
> typedef unsigned int __u32;
> #include <linux/header.h>
>
> Which is just horribly broken when it's included early in a file and
> then we try to #include <asm/sigcontext.h> (and doesn't get the rest
> of those types since it now includes <linux/types.h> instead of
> <asm/types.h>) (coreutils was doing this.)
>
> The real case is something like using the dvb headers, which legitimately
> is trying to include both <sys/*.h> and then <linux/dvb/*.h> and expecting
> it to work.
>
> The footnote in the prior mail was really just an example of why not
> having just the plain __u32 et al types in their own header.
>
Because <linux/types.h> should work just fine once we get rid of the
__KERNEL_STRICT_NAMES idiocy?
FWIW, Arnd Bergmann has been working on exactly this cleanup.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-02-25 7:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 3:25 [rfc] headers_check cleanups break the whole world Kyle McMartin
2009-02-25 6:24 ` H. Peter Anvin
2009-02-25 6:56 ` Ingo Molnar
2009-02-25 7:00 ` H. Peter Anvin
2009-02-25 7:05 ` Kyle McMartin
2009-02-25 7:08 ` H. Peter Anvin [this message]
2009-02-25 7:13 ` Kyle McMartin
2009-02-25 7:16 ` H. Peter Anvin
2009-02-25 7:22 ` Kyle McMartin
2009-02-25 18:17 ` [PATCH] Make exported headers use strict posix types Arnd Bergmann
2009-02-25 20:11 ` Sam Ravnborg
2009-02-25 21:42 ` Arnd Bergmann
2009-02-25 21:58 ` Arnd Bergmann
2009-02-25 22:07 ` H. Peter Anvin
2009-02-25 22:39 ` David Woodhouse
2009-02-25 23:58 ` H. Peter Anvin
2009-02-25 23:07 ` H. Peter Anvin
2009-02-26 0:01 ` Arnd Bergmann
2009-02-26 0:04 ` H. Peter Anvin
2009-02-25 11:34 ` [rfc] headers_check cleanups break the whole world Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A4EE85.5000907@zytor.com \
--to=hpa@zytor.com \
--cc=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=jaswinderrajput@gmail.com \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox