From: Frank Seidel <fseidel@suse.de>
To: Frank Seidel <fseidel@suse.de>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, akpm@linux-foundation.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
nhorman@tuxdriver.com, lho@amcc.com, kaber@trash.net,
darrenrjenkins@gmail.com, Frank Seidel <frank@f-seidel.de>
Subject: [PATCHv3][trivial] crypto: tcrypt - reduce stack size
Date: Wed, 25 Feb 2009 15:53:14 +0100 [thread overview]
Message-ID: <49A55B5A.70705@suse.de> (raw)
In-Reply-To: <49A5549F.4070304@suse.de>
From: Frank Seidel <frank@f-seidel.de>
Applying kernel janitors todos (printk calls need KERN_*
constants on linebeginnings, reduce stack footprint where
possible) to tcrypts test_hash_speed (where stacks
memory footprint was very high (on i386 1184 bytes to
160 now).
Signed-off-by: Frank Seidel <frank@f-seidel.de>
---
crypto/tcrypt.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -396,16 +396,16 @@ static void test_hash_speed(const char *
struct scatterlist sg[TVMEMSIZE];
struct crypto_hash *tfm;
struct hash_desc desc;
- char output[1024];
+ static char output[1024];
int i;
int ret;
- printk("\ntesting speed of %s\n", algo);
+ printk(KERN_INFO "\ntesting speed of %s\n", algo);
tfm = crypto_alloc_hash(algo, 0, CRYPTO_ALG_ASYNC);
if (IS_ERR(tfm)) {
- printk("failed to load transform for %s: %ld\n", algo,
+ printk(KERN_ERR "failed to load transform for %s: %ld\n", algo,
PTR_ERR(tfm));
return;
}
@@ -414,7 +414,7 @@ static void test_hash_speed(const char *
desc.flags = 0;
if (crypto_hash_digestsize(tfm) > sizeof(output)) {
- printk("digestsize(%u) > outputbuffer(%zu)\n",
+ printk(KERN_ERR "digestsize(%u) > outputbuffer(%zu)\n",
crypto_hash_digestsize(tfm), sizeof(output));
goto out;
}
@@ -427,12 +427,14 @@ static void test_hash_speed(const char *
for (i = 0; speed[i].blen != 0; i++) {
if (speed[i].blen > TVMEMSIZE * PAGE_SIZE) {
- printk("template (%u) too big for tvmem (%lu)\n",
+ printk(KERN_ERR
+ "template (%u) too big for tvmem (%lu)\n",
speed[i].blen, TVMEMSIZE * PAGE_SIZE);
goto out;
}
- printk("test%3u (%5u byte blocks,%5u bytes per update,%4u updates): ",
+ printk(KERN_INFO "test%3u "
+ "(%5u byte blocks,%5u bytes per update,%4u updates): ",
i, speed[i].blen, speed[i].plen, speed[i].blen / speed[i].plen);
if (sec)
@@ -443,7 +445,7 @@ static void test_hash_speed(const char *
speed[i].plen, output);
if (ret) {
- printk("hashing failed ret=%d\n", ret);
+ printk(KERN_ERR "hashing failed ret=%d\n", ret);
break;
}
}
next prev parent reply other threads:[~2009-02-25 14:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 13:48 [PATCH][trivial] crypto: tcrypt - reduce stack size Frank Seidel
2009-02-25 14:06 ` Thiago Galesi
2009-02-25 14:06 ` Neil Horman
2009-02-25 14:20 ` Herbert Xu
2009-02-25 14:24 ` Frank Seidel
2009-02-25 14:27 ` Herbert Xu
2009-02-25 14:31 ` Geert Uytterhoeven
2009-02-25 14:36 ` Frank Seidel
2009-02-25 14:44 ` Geert Uytterhoeven
2009-02-25 14:54 ` Frank Seidel
2009-02-25 14:29 ` Thiago Galesi
2009-02-25 14:34 ` Frank Seidel
2009-02-25 19:40 ` Greg KH
2009-02-25 14:24 ` [PATCHv2][trivial] " Frank Seidel
2009-02-25 14:53 ` Frank Seidel [this message]
2009-02-25 15:32 ` [PATCHv3][trivial] " Neil Horman
2009-03-29 7:19 ` Herbert Xu
2009-02-25 15:54 ` Geert Uytterhoeven
2009-02-25 15:56 ` Frank Seidel
2009-02-25 15:58 ` Geert Uytterhoeven
2009-02-25 16:01 ` Frank Seidel
2009-02-25 16:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A55B5A.70705@suse.de \
--to=fseidel@suse.de \
--cc=akpm@linux-foundation.org \
--cc=darrenrjenkins@gmail.com \
--cc=davem@davemloft.net \
--cc=frank@f-seidel.de \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=lho@amcc.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox