public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frank Seidel <fseidel@suse.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Frank Seidel <fseidel@suse.de>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux kernel <linux-kernel@vger.kernel.org>,
	linux-crypto@vger.kernel.org, akpm@linux-foundation.org,
	"David S. Miller" <davem@davemloft.net>,
	nhorman@tuxdriver.com, lho@amcc.com, kaber@trash.net,
	darrenrjenkins@gmail.com, Greg KH <gregkh@suse.de>,
	Frank Seidel <frank@f-seidel.de>
Subject: Re: [PATCH][trivial] crypto: tcrypt - reduce stack size
Date: Wed, 25 Feb 2009 15:54:32 +0100	[thread overview]
Message-ID: <49A55BA8.2060205@suse.de> (raw)
In-Reply-To: <alpine.LRH.2.00.0902251542010.15476@vixen.sonytel.be>

Geert Uytterhoeven wrote:
> On Wed, 25 Feb 2009, Frank Seidel wrote:
> Wel...
> 
> Using kmalloc() increases code size, makes the code more complex, and increases
> the risk of introducing a memory leak now or later.

Ok, admitted.

>> I just stumbled over tcrypt on the make checkstack output and as also
>> the kerneljanitors todo advises to reduce this footprint where possible
>> i just wanted to help out here.
> 
> Reducing stack usage is fine. However, for a loadable test module without
> concurrency issues it's far easier to do that by just making the data static.

Is PATCHv3 then ok for you?

Thanks,
Frank

  reply	other threads:[~2009-02-25 14:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 13:48 [PATCH][trivial] crypto: tcrypt - reduce stack size Frank Seidel
2009-02-25 14:06 ` Thiago Galesi
2009-02-25 14:06 ` Neil Horman
2009-02-25 14:20 ` Herbert Xu
2009-02-25 14:24   ` Frank Seidel
2009-02-25 14:27     ` Herbert Xu
2009-02-25 14:31       ` Geert Uytterhoeven
2009-02-25 14:36         ` Frank Seidel
2009-02-25 14:44           ` Geert Uytterhoeven
2009-02-25 14:54             ` Frank Seidel [this message]
2009-02-25 14:29     ` Thiago Galesi
2009-02-25 14:34       ` Frank Seidel
2009-02-25 19:40         ` Greg KH
2009-02-25 14:24 ` [PATCHv2][trivial] " Frank Seidel
2009-02-25 14:53   ` [PATCHv3][trivial] " Frank Seidel
2009-02-25 15:32     ` Neil Horman
2009-03-29  7:19       ` Herbert Xu
2009-02-25 15:54     ` Geert Uytterhoeven
2009-02-25 15:56       ` Frank Seidel
2009-02-25 15:58         ` Geert Uytterhoeven
2009-02-25 16:01           ` Frank Seidel
2009-02-25 16:08           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A55BA8.2060205@suse.de \
    --to=fseidel@suse.de \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=darrenrjenkins@gmail.com \
    --cc=davem@davemloft.net \
    --cc=frank@f-seidel.de \
    --cc=gregkh@suse.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=kaber@trash.net \
    --cc=lho@amcc.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox