From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756550AbZBZBCU (ORCPT ); Wed, 25 Feb 2009 20:02:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752918AbZBZBCF (ORCPT ); Wed, 25 Feb 2009 20:02:05 -0500 Received: from terminus.zytor.com ([198.137.202.10]:36029 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbZBZBCC (ORCPT ); Wed, 25 Feb 2009 20:02:02 -0500 Message-ID: <49A5E876.1000501@zytor.com> Date: Wed, 25 Feb 2009 16:55:18 -0800 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: David Howells CC: Justin Chen , linux-arch@vger.kernel.org, bjorn.helgaas@hp.com, justin.chen@hp.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv] References: <49A5C754.7000408@zytor.com> <200902250452.UAA12902@hpdst41.cup.hp.com> <16693.1235565430@redhat.com> <7355.1235605851@redhat.com> In-Reply-To: <7355.1235605851@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > >> A casual grep finds no less than 3524 instances of "static inline " -- >> presumably with a function name following -- and only 447 instances of >> "static inline" without a type in the kernel. > > But how does it break down between "static inline type\nfunction_name" and > "static inline\ntype function_name"? That's more to the point. > I believe that is the breakdown is roughly what you see above, i.e. over 8:1; the pattern I used was looking for "^static inline[^;(]*$", and a visual examination of the results shows that even if my line count is slighly off the lopsidedness is still dramatic. -hpa