Re: [RFC] introduce pr_cont macro

Ingo Molnar
2009-02-26T03:03:31Z

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> We cover all log-levels by pr_... macros except
> KERN_CONT one. Add it for convenience.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
>
> I think start printing with some pr_... macro
> and continue with printk(KERN_CONT ...) look
> not that clear -- better to continue with
> same pr_... slogan. Thoughts? I hope I didn't
> miss anything.
>
> include/linux/kernel.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6.git/include/linux/kernel.h
> ===================================================================
> --- linux-2.6.git.orig/include/linux/kernel.h
> +++ linux-2.6.git/include/linux/kernel.h
> @@ -370,6 +370,8 @@ static inline char *pack_hex_byte(char *
> printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
> #define pr_info(fmt, ...) \
> printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> +#define pr_cont(fmt, ...) \
> + printk(KERN_CONT pr_fmt(fmt), ##__VA_ARGS__)

Makes sense.

Acked-by: Ingo Molnar <mingo@elte.hu>

Ingo