Re: [PATCH 1/1] ath5k: fix hw rate index condition

Bob Copeland
2009-02-15T13:47:48Z

On Mon, Feb 02, 2009 at 01:27:39PM +0530, Dhaval Giani wrote:
> So I finally managed to hit this on 2.6.29-rc3. It is hard to
> reproduce, so I hope so much information is enough to give you a good
> guess. This time it hit while trying to connect to an open network at
> the airport.

> WARNING: at net/mac80211/rx.c:2236 __ieee80211_rx+0x96/0x571 [mac80211]()
> Hardware name: 2007CS3
> RATE=255, BAND=8

band is supposed to be sc->curband? 8 is way wrong. rate could be 255
if, for some reason, the hardware rate wasn't in the rate table.

> Pid: 2634, comm: X Not tainted 2.6.29-rc3 #18
> Call Trace:
> [<c0430636>] warn_slowpath+0x76/0xad
> [<c04508d7>] ? __lock_acquire+0xb36/0xb45
> [<f7dd0205>] __ieee80211_rx+0x96/0x571 [mac80211]
> [<f7e37976>] ath5k_tasklet_rx+0x4fb/0x53d [ath5k]
> [<c06fa5c3>] ? _spin_unlock_irq+0x27/0x34
> [<c0434f91>] tasklet_action+0x85/0xf0

Interestingly I hit this just the other day -- I was debugging something
else and had a serial console hooked up, otherwise I wouldn't have
noticed at all. It happened at some point during a suspend-to-ram
sequence, which makes at least my version sound like a race condition
of some sort.