Re: [ath5k-devel] [PATCH 1/1] ath5k: fix hw rate index condition

Bob Copeland
2009-03-03T13:03:22Z

On Tue, Mar 03, 2009 at 06:31:05AM +0200, Nick Kossifidis wrote:
>
> According to docs the rate field is only valid if more flag is clear
> (we have the last descriptor) and only if the receive ok flag is set
> or both receive ok and phy error flags are cleared. We never do such
> checks so we might actually try to process this field when we already
> know we shouldn't...

Well, we do skip rs_more packets without getting the rate, hopefully
phy error packets too. The warning would definitely show if we have
any bugs there.

> Also the following rate codes are reserved (except XR codes that we
> already know):
[snip]
> and i don't believe i've ever seen them, so we can warn on them too
> and print something like "Reserved rate code: %x", also it would be
> nice to warn on XR rates (1,2,3,6,7) in case we want to debug this in
> the future.

Good idea, though I'm somewhat of the mind that we should let the
current patch go in for a bit and see if any of these pop up. But
that's because I'm lazy :)