From: Milan Broz <mbroz@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Huang Ying <ying.huang@intel.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: Bug of dm-crypt?
Date: Fri, 27 Feb 2009 09:41:02 +0100 [thread overview]
Message-ID: <49A7A71E.50702@redhat.com> (raw)
In-Reply-To: <20090227054147.GA22159@gondor.apana.org.au>
Herbert Xu wrote:
> On Fri, Feb 27, 2009 at 01:31:56PM +0800, Huang Ying wrote:
>> I had ever heard from you that the only thing guaranteed in the
>> completion function of async ablkcipher cryption is the req->data has
>> the value you set before. The request pointer itself may be changed. But
>> in dm-crypt, I found they rely on request pointer in completion
>> function: kcryptd_async_done. This makes my AES-NI cryptd usage panic.
>>
>> Do you think that is a bug?
>
> Absolutely.
>
> It should use cc->req instead.
ok, I'll check it and try to fix that.
Can you send me backtrace from that panic?
What's wrong in async callback now - mempool_free using async_req directly?
(Btw in some previous discussuion I asked if cryptd can be used
for some kind of parallel speedup for dm-crypt in async mode and response
was that cryptd "is only meant to be a demo showing how an async
implementation should be written".
So this changed to real working thread for AES-NI?)
Milan
--
mbroz@redhat.com
next prev parent reply other threads:[~2009-02-27 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 5:31 Bug of dm-crypt? Huang Ying
2009-02-27 5:41 ` Herbert Xu
2009-02-27 8:41 ` Milan Broz [this message]
2009-02-27 9:46 ` Huang Ying
2009-02-27 11:39 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A7A71E.50702@redhat.com \
--to=mbroz@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox