Re: [PATCH] Cleanup patch for RS485 on Cris architecture

[Claudio Scordino <claudio@evidence.eu.com>]

Andrew Morton ha scritto:
> On Wed, 25 Feb 2009 11:07:52 +0100
> Claudio Scordino <claudio@evidence.eu.com> wrote:
> 
>> Dear Alan, dear Andrew,
>>
>>      around one month ago I submitted a cleanup patch to use the new 
>> general RS485 Linux data structure (introduced by Alan with commit 
>> number c26c56c0f40e200e61d1390629c806f6adaffbcc) in the Cris 
>> architecture too (currently, Cris still uses the old private data 
>> structure instead of the new one).
>>
>> The code compiled, but I couldn't test it at that time.
>>
>> Now, the code has been tested by Hinko Kocevar and Janez Cufer 
>> (CC:-ed) from the AXIS group, who also fixed a bug.
>>
>> Therefore, can you please commit the patch in attachment ?
>>
>> Many thanks,
>>
>>              Claudio Scordino
>>
>>
>> [0001-RS485-support-on-Cris-rewritten-in-order-to-use-new.patch  text/x-diff (9.9KB)]
>> >From 9d4397feff9773820e158693aa73621c0c20f017 Mon Sep 17 00:00:00 2001
>> From: Claudio Scordino <claudio@evidence.eu.com>
>> Date: Tue, 24 Feb 2009 18:00:44 +0100
>> Subject: [PATCH 1/1] RS485 support on Cris rewritten in order to use new serial_rs485 data structure
>>
>>
>> Signed-off-by: Claudio Scordino <claudio@evidence.eu.com>
>> Tested-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
>> Tested-by: Janez Cufer <janez.cufer@cetrtapot.si>
> 
> The patch had no changelog - please always provide one.

Sorry, my apologies... Next time I'll keep in mind!

> 
> I scraped some text from your covering comment and made this:
> 
>     Use the new general RS485 Linux data structure (introduced by
>     Alan with commit number c26c56c0f40e200e61d1390629c806f6adaffbcc)
>     in the Cris architecture too (currently, Cris still uses the old
>     private data structure instead of the new one).
> 
> for a changelog.  Feel free to send better text if that is inappropriate
> or incomplete.

This changelog is perfect.

Many thanks,

          Claudio