From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755871AbZB0Iql (ORCPT ); Fri, 27 Feb 2009 03:46:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752987AbZB0Iqc (ORCPT ); Fri, 27 Feb 2009 03:46:32 -0500 Received: from mailgate5.9netweb.it ([66.71.190.74]:47514 "EHLO mailgate5.9netweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbZB0Iqb (ORCPT ); Fri, 27 Feb 2009 03:46:31 -0500 Message-ID: <49A7A845.2030709@evidence.eu.com> Date: Fri, 27 Feb 2009 09:45:57 +0100 From: Claudio Scordino User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Andrew Morton Cc: alan@lxorguk.ukuu.org.uk, alan@redhat.com, hinko.kocevar@cetrtapot.si, janez.cufer@cetrtapot.si, starvik@axis.com, jesper.nilsson@axis.com, apw@canonical.com, linux-kernel@vger.kernel.org, dev-etrax@axis.com Subject: Re: [PATCH] Cleanup patch for RS485 on Cris architecture References: <49A51878.7020206@evidence.eu.com> <20090226134924.e4d88605.akpm@linux-foundation.org> In-Reply-To: <20090226134924.e4d88605.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton ha scritto: > On Wed, 25 Feb 2009 11:07:52 +0100 > Claudio Scordino wrote: > >> Dear Alan, dear Andrew, >> >> around one month ago I submitted a cleanup patch to use the new >> general RS485 Linux data structure (introduced by Alan with commit >> number c26c56c0f40e200e61d1390629c806f6adaffbcc) in the Cris >> architecture too (currently, Cris still uses the old private data >> structure instead of the new one). >> >> The code compiled, but I couldn't test it at that time. >> >> Now, the code has been tested by Hinko Kocevar and Janez Cufer >> (CC:-ed) from the AXIS group, who also fixed a bug. >> >> Therefore, can you please commit the patch in attachment ? >> >> Many thanks, >> >> Claudio Scordino >> >> >> [0001-RS485-support-on-Cris-rewritten-in-order-to-use-new.patch text/x-diff (9.9KB)] >> >From 9d4397feff9773820e158693aa73621c0c20f017 Mon Sep 17 00:00:00 2001 >> From: Claudio Scordino >> Date: Tue, 24 Feb 2009 18:00:44 +0100 >> Subject: [PATCH 1/1] RS485 support on Cris rewritten in order to use new serial_rs485 data structure >> >> >> Signed-off-by: Claudio Scordino >> Tested-by: Hinko Kocevar >> Tested-by: Janez Cufer > > The patch had no changelog - please always provide one. Sorry, my apologies... Next time I'll keep in mind! > > I scraped some text from your covering comment and made this: > > Use the new general RS485 Linux data structure (introduced by > Alan with commit number c26c56c0f40e200e61d1390629c806f6adaffbcc) > in the Cris architecture too (currently, Cris still uses the old > private data structure instead of the new one). > > for a changelog. Feel free to send better text if that is inappropriate > or incomplete. This changelog is perfect. Many thanks, Claudio