From: "H. Peter Anvin" <hpa@zytor.com>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Tim Abbott <tabbott@MIT.EDU>,
linux-kernel@vger.kernel.org, Jeff Arnold <jbarnold@MIT.EDU>,
Waseem Daher <wdaher@MIT.EDU>,
Denys Vlasenko <vda.linux@googlemail.com>,
Nikanth Karthikesan <knikanth@suse.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] modpost: Check the section flags, not name, to catch missing "ax"/"aw"
Date: Fri, 27 Feb 2009 04:35:25 -0800 [thread overview]
Message-ID: <49A7DE0D.5090205@zytor.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0902262057080.9996@vinegar-pot.mit.edu>
Anders Kaseorg wrote:
> On Tue, 24 Feb 2009, H. Peter Anvin wrote:
>> This is a pretty critical set of warnings, that often represent real
>> bugs. I don't think it's acceptable to lose them. However, you already
>> have (prior in the sequence) changed those section names to not conflict
>> with the automatically generated ones, so it seems to me that this
>> should be fixable without too much pain.
>
> Actually, the problem arises from a conflict between two classes of
> automatically generated section names, one from ld, and one from gcc.
> Instead of basing the warning on section names (the existing heuristic
> also fails to warn on some cases where it should, as it turns out), what
> do you think about this patch? I've tested that it still triggers the
> warning when an "ax" or "aw" is incorrectly removed, and it should handle
> even more cases than before.
>
Seems reasonable to me.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
prev parent reply other threads:[~2009-02-27 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 0:21 [PATCH v2 0/4] Ksplice: Rebootless kernel updates Tim Abbott
2009-02-25 0:21 ` [PATCH v2 1/4] Make section names compatible with -ffunction-sections -fdata-sections Tim Abbott
2009-02-25 0:21 ` [PATCH v2 2/4] x86: Add an option to compile " Tim Abbott
2009-02-25 0:21 ` [PATCH v2 3/4] Ksplice: Export symbols needed for Ksplice Tim Abbott
2009-02-25 0:21 ` [PATCH v2 4/4] Ksplice: Support updating x86-32 and x86-64 Tim Abbott
2009-02-25 1:21 ` [PATCH v2 2/4] x86: Add an option to compile with -ffunction-sections -fdata-sections H. Peter Anvin
2009-02-27 2:10 ` [PATCH] modpost: Check the section flags, not name, to catch missing "ax"/"aw" Anders Kaseorg
2009-02-27 12:35 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A7DE0D.5090205@zytor.com \
--to=hpa@zytor.com \
--cc=andersk@MIT.EDU \
--cc=andi@firstfloor.org \
--cc=jbarnold@MIT.EDU \
--cc=knikanth@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tabbott@MIT.EDU \
--cc=vda.linux@googlemail.com \
--cc=wdaher@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox