From: Wang Chen <wangchen@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] sched: kill unused parameter of pick_next_task()
Date: Mon, 02 Mar 2009 13:55:26 +0800 [thread overview]
Message-ID: <49AB74CE.2000200@cn.fujitsu.com> (raw)
based on tip/sched/cleanups
impact: no change in functionality
Parameter "prev" seems like an unusable thing.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
kernel/sched.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 410eec4..57f8b12 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4512,7 +4512,7 @@ static inline void schedule_debug(struct task_struct *prev)
* Pick up the highest-prio task:
*/
static inline struct task_struct *
-pick_next_task(struct rq *rq, struct task_struct *prev)
+pick_next_task(struct rq *rq)
{
const struct sched_class *class;
struct task_struct *p;
@@ -4587,7 +4587,7 @@ need_resched_nonpreemptible:
idle_balance(cpu, rq);
prev->sched_class->put_prev_task(rq, prev);
- next = pick_next_task(rq, prev);
+ next = pick_next_task(rq);
if (likely(prev != next)) {
sched_info_switch(prev, next);
@@ -6423,7 +6423,7 @@ static void migrate_dead_tasks(unsigned int dead_cpu)
if (!rq->nr_running)
break;
update_rq_clock(rq);
- next = pick_next_task(rq, rq->curr);
+ next = pick_next_task(rq);
if (!next)
break;
next->sched_class->put_prev_task(rq, next);
--
1.5.3.4
next reply other threads:[~2009-03-02 5:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 5:55 Wang Chen [this message]
2009-03-02 6:13 ` [PATCH] sched: kill unused parameter of pick_next_task() Américo Wang
2009-03-02 6:52 ` Wang Chen
2009-03-02 7:44 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AB74CE.2000200@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox