From: Mike Waychison <mikew@google.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Paul Menage <menage@google.com>,
Containers <containers@lists.linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux@smtp1.linux-foundation.org
Subject: Re: [PATCH 0/4] cgroups: show correct file mode
Date: Mon, 02 Mar 2009 16:23:57 -0800 [thread overview]
Message-ID: <49AC789D.5050209@google.com> (raw)
In-Reply-To: <20090303092021.93e69b96.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Mon, 2 Mar 2009 16:15:51 -0800
> Paul Menage <menage@google.com> wrote:
>
>> On Mon, Mar 2, 2009 at 4:09 PM, KAMEZAWA Hiroyuki
>> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>>> int mode;
>>> if (cft->mode)
>>> mode = cft->mode;
>>> else if (cft->write_xxx || .....)
>>> mode = 0644;
>>> else
>>> mode = 0444;
>> Almost:
>>
>> int mode;
>> if (cft->mode) {
>> mode = cft->mode;
>> } else {
>> if (cft->write_xxx || ....)
>> mode |= 0600;
0200 ?
>> if (cft->read_xxx || ...)
>> mode |= 0444;
>> }
>>
> Oh, I see. But int mode=0, at first ;)
> I have no objections but please forgive subsys to set mode=0644 explicitly.
>
> Thanks,
> -Kame
>
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
next prev parent reply other threads:[~2009-03-03 0:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 2:13 [PATCH 0/4] cgroups: show correct file mode Li Zefan
2009-03-02 2:13 ` [PATCH 1/4] cgroup debug: " Li Zefan
2009-03-02 2:14 ` [PATCH 2/4] cpuacct: " Li Zefan
2009-03-02 2:15 ` [PATCH 3/4] devcgroup: " Li Zefan
2009-03-02 13:06 ` Serge E. Hallyn
2009-03-02 2:16 ` [PATCH 4/4] cpuset: " Li Zefan
2009-03-02 18:19 ` [PATCH 0/4] cgroups: " Paul Menage
2009-03-03 0:09 ` KAMEZAWA Hiroyuki
2009-03-03 0:15 ` Paul Menage
2009-03-03 0:20 ` KAMEZAWA Hiroyuki
2009-03-03 0:23 ` Paul Menage
2009-03-03 0:23 ` Mike Waychison [this message]
2009-03-03 0:26 ` Paul Menage
2009-03-03 1:08 ` Li Zefan
2009-03-03 1:08 ` KAMEZAWA Hiroyuki
2009-03-03 1:15 ` Li Zefan
2009-03-03 1:19 ` KAMEZAWA Hiroyuki
2009-03-03 1:16 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AC789D.5050209@google.com \
--to=mikew@google.com \
--cc=Linux@smtp1.linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox