Re: [PATCH 6/6 v6] SGI RTC: add clocksource driver

john stultz
2009-03-03T20:02:22Z

On Tue, 2009-03-03 at 09:22 -0600, Dimitri Sivanich wrote:
> This patch provides a driver for SGI RTC clocks and timers.
>
> This provides a high resolution clock and timer source using the SGI
> system-wide synchronized RTC clock/timer hardware.
>
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
>
> ---
>
> Implemented suggested changes and refreshed for latest -tip.
>
> drivers/clocksource/Makefile | 1
> drivers/clocksource/rtc_uv.c | 381 +++++++++++++++++++++++++++++++++++++++
> drivers/misc/Kconfig | 9
> 3 files changed, 391 insertions(+)
[snip]
> +
> +static struct clocksource clocksource_uv = {
> + .name = RTC_NAME,
> + .rating = 400,
> + .read = uv_read_rtc,
> + .mask = (cycle_t)UVH_RTC_REAL_TIME_CLOCK_MASK,
> + .shift = 10,

What is the expected value for sn_rtc_cycles_per_second ?

I ask because a shift value of 10 seems a bit low. It could very well be
appropriate, but I just wanted to check.

thanks
-john