From: Tejun Heo <tj@kernel.org>
To: Stefan Lippers-Hollmann <s.L-H@gmx.de>
Cc: Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, stable@kernel.org,
Robert Hancock <hancockr@shaw.ca>,
Jeff Garzik <jgarzik@redhat.com>,
saro_v@hotmail.it
Subject: Re: [patch 05/39] sata_nv: give up hardreset on nf2
Date: Wed, 04 Mar 2009 11:12:14 +0900 [thread overview]
Message-ID: <49ADE37E.1040000@kernel.org> (raw)
In-Reply-To: <200903040053.36626.s.L-H@gmx.de>
Hello, Stefan.
Stefan Lippers-Hollmann wrote:
> Hi
>
> On Mittwoch, 18. Februar 2009, Greg KH wrote:
>> 2.6.28-stable review patch. If anyone has any objections, please let us know.
> [...]
>> From: Tejun Heo <tj@kernel.org>
>>
>> commit 7dac745b8e367c99175b8f0d014d996f0e5ed9e5 upstream.
>>
>> Kernel bz#12176 reports that nf2 hardreset simply doesn't work. Give
>> up. Argh...
>
> Sorry to report this rather late, but I upgraded a remote nforce3 system to
> 2.6.28.7 today, and noticed the following messages repeating continously
> (reproducable on a different nforce3 system as well):
>
> ata4: EH pending after 5 tries, giving up
> ata4: EH complete
> ata4: EH pending after 5 tries, giving up
> ata4: EH complete
>
> Reverting just this patch from 2.6.28.7 lets them disappear again. Likewise
> 2.6.29-rc6-git7 is affected as well - and reverting this patch seems to fix
> the issue there as well.
This is reported in bko#11615. I don't quite understand it yet. The
only thing that should have changed is the use of softreset instead of
hardreset and changing inheritance to nv_generic_ops should have done
exactly that in a very safe way. Apparently, it didn't. I'll dig
into what went wrong.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-03-04 2:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090218212144.965748151@mini.kroah.org>
2009-02-18 21:30 ` [patch 00/39] 2.6.28.7-stable review Greg KH
2009-02-18 21:32 ` [patch 01/39] pid: implement ns_of_pid Greg KH
2009-02-18 21:32 ` [patch 02/39] mqueue: fix si_pid value in mqueue do_notify() Greg KH
2009-02-18 21:32 ` [patch 03/39] WATCHDOG: iTCO_wdt: fix SMI_EN regression 2 Greg KH
2009-02-18 21:32 ` [patch 04/39] powerpc/vsx: Fix VSX alignment handler for regs 32-63 Greg KH
2009-02-18 21:32 ` [patch 05/39] sata_nv: give up hardreset on nf2 Greg KH
2009-03-03 23:53 ` Stefan Lippers-Hollmann
2009-03-04 2:12 ` Tejun Heo [this message]
2009-02-18 21:32 ` [patch 06/39] Fix Intel IOMMU write-buffer flushing Greg KH
2009-02-18 21:32 ` [patch 07/39] SCSI: libiscsi: fix iscsi pool leak Greg KH
2009-02-18 21:32 ` [patch 08/39] x86/cpa: make sure cpa is safe to call in lazy mmu mode Greg KH
2009-02-18 21:32 ` [patch 09/39] sched: SCHED_OTHER vs SCHED_IDLE isolation Greg KH
2009-02-18 21:32 ` [patch 10/39] x86, vm86: fix preemption bug Greg KH
2009-02-18 21:32 ` [patch 11/39] Add support for VT6415 PCIE PATA IDE Host Controller Greg KH
2009-02-18 21:32 ` [patch 12/39] ext2/xip: refuse to change xip flag during remount with busy inodes Greg KH
2009-02-18 21:32 ` [patch 13/39] 3c505: do not set pcb->data.raw beyond its size Greg KH
2009-02-18 21:32 ` [patch 14/39] Bluetooth: Fix TX error path in btsdio driver Greg KH
2009-02-18 21:32 ` [patch 15/39] ext4: Add support for non-native signed/unsigned htree hash algorithms Greg KH
2009-02-18 21:32 ` [patch 16/39] ext4: tone down ext4_da_writepages warnings Greg KH
2009-02-18 21:32 ` [patch 17/39] ext4: Fix the delalloc writepages to allocate blocks at the right offset Greg KH
2009-02-18 21:32 ` [patch 18/39] ext4: avoid ext4_error when mounting a fs with a single bg Greg KH
2009-02-18 21:32 ` [patch 19/39] ext4: Widen type of ext4_sb_info.s_mb_maxs[] Greg KH
2009-02-18 21:32 ` [patch 20/39] jbd2: Add barrier not supported test to journal_wait_on_commit_record Greg KH
2009-02-18 21:32 ` [patch 21/39] ext4: Dont overwrite allocation_context ac_status Greg KH
2009-02-18 21:32 ` [patch 22/39] ext4: Add blocks added during resize to bitmap Greg KH
2009-02-18 21:32 ` [patch 23/39] ext4: Use EXT4_GROUP_INFO_NEED_INIT_BIT during resize Greg KH
2009-02-18 21:32 ` [patch 24/39] ext4: cleanup mballoc header files Greg KH
2009-02-18 21:33 ` [patch 25/39] ext4: dont use blocks freed but not yet committed in buddy cache init Greg KH
2009-02-18 21:33 ` [patch 26/39] ext4: Fix race between read_block_bitmap() and mark_diskspace_used() Greg KH
2009-02-18 21:33 ` [patch 27/39] ext4: Fix the race between read_inode_bitmap() and ext4_new_inode() Greg KH
2009-02-18 21:33 ` [patch 28/39] jbd2: Add BH_JBDPrivateStart Greg KH
2009-02-18 21:33 ` [patch 29/39] ext4: Use new buffer_head flag to check uninit group bitmaps initialization Greg KH
2009-02-18 21:33 ` [patch 30/39] ext4: mark the blocks/inode bitmap beyond end of group as used Greg KH
2009-02-18 21:33 ` [patch 31/39] ext4: Dont allow new groups to be added during block allocation Greg KH
2009-02-18 21:33 ` [patch 32/39] ext4: Init the complete page while building buddy cache Greg KH
2009-02-18 21:33 ` [patch 33/39] ext4: Fix s_dirty_blocks_counter if block allocation failed with nodelalloc Greg KH
2009-02-18 21:33 ` [patch 34/39] ext4: Add sanity checks for the superblock before mounting the filesystem Greg KH
2009-02-18 21:33 ` [patch 35/39] ext4: only use i_size_high for regular files Greg KH
2009-02-18 21:33 ` [patch 36/39] ext4: Add sanity check to make_indexed_dir Greg KH
2009-02-18 21:33 ` [patch 37/39] jbd2: On a __journal_expect() assertion failure printk "JBD2", not "EXT3-fs" Greg KH
2009-02-18 21:33 ` [patch 38/39] ext4: Initialize the new group descriptor when resizing the filesystem Greg KH
2009-02-18 21:33 ` [patch 39/39] Fix longstanding "error: storage size of __mod_dmi_device_table isnt known" Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ADE37E.1040000@kernel.org \
--to=tj@kernel.org \
--cc=gregkh@suse.de \
--cc=hancockr@shaw.ca \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.L-H@gmx.de \
--cc=saro_v@hotmail.it \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox