From: Tejun Heo <tj@kernel.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
pgnet.trash@gmail.com
Subject: [PATCH 2.6.29-rc7 2/2] x86: disallow DAC for MCP51 PCI bridge
Date: Wed, 04 Mar 2009 11:39:15 +0900 [thread overview]
Message-ID: <49ADE9D3.6080000@kernel.org> (raw)
In-Reply-To: <49ADE82D.40103@kernel.org>
MCP51 corrupts DAC transfers. Disallow it. Reported by pgnet on
bnc#463829.
https://bugzilla.novell.com/show_bug.cgi?id=463829
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: pgnet <pgnet.trash@gmail.com>
---
arch/x86/kernel/pci-dma.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index b254285..7b61798 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -296,4 +296,18 @@ static __devinit void via_no_dac(struct pci_dev *dev)
}
}
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_ANY_ID, via_no_dac);
+
+/*
+ * MCP51 PCI bridge corrupts data for DAC. Disable it. Reported in
+ * bnc#463829.
+ */
+static __devinit void mcp51_no_dac(struct pci_dev *dev)
+{
+ if (forbid_dac == 0) {
+ printk(KERN_INFO
+ "PCI: MCP51 PCI bridge detected. Disabling DAC.\n");
+ forbid_dac = 1;
+ }
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x026f, mcp51_no_dac);
#endif
next prev parent reply other threads:[~2009-03-04 2:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 2:32 [PATCH 2.6.29-rc7 1/2] x86: fix iommu=nodac parameter handling Tejun Heo
2009-03-04 2:39 ` Tejun Heo [this message]
2009-03-04 9:57 ` [PATCH 2.6.29-rc7 2/2] x86: disallow DAC for MCP51 PCI bridge Alan Cox
2009-03-04 10:11 ` Tejun Heo
2009-03-04 13:29 ` Alan Cox
2009-03-04 13:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ADE9D3.6080000@kernel.org \
--to=tj@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pgnet.trash@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox