Re: x86-tip: cpufreq breakage - bisection fingers 89c9215165ca609096e845926d9a18f1306176a4

[Tejun Heo <tj@kernel.org>]

Tejun Heo wrote:
> Hello, Mike.
> 
> Mike Galbraith wrote:
>> On Wed, 2009-03-04 at 04:43 +0100, Mike Galbraith wrote:
>>> On Wed, 2009-03-04 at 10:59 +0900, Tejun Heo wrote:
>>>
>>>> I can't reproduce the problem here.
>>> Guess I'll have to sharpen a stick or two then.
>> With monkey-see-monkey-do-stick, box becomes happy camper again.
>>
>> diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c
>> index c29f301..bc9972a 100644
>> --- a/arch/x86/kernel/setup_percpu.c
>> +++ b/arch/x86/kernel/setup_percpu.c
>> @@ -256,6 +256,11 @@ static struct page * __init pcpue_get_page(unsigned int cpu, int pageno)
>>  			    + ((size_t)pageno << PAGE_SHIFT));
>>  }
>>  
>> +static void __init embed_populate_pte(unsigned long addr)
>> +{
>> +	populate_extra_pte(addr);
>> +}
>> +
>>  static ssize_t __init setup_pcpu_embed(size_t static_size)
>>  {
>>  	unsigned int cpu;
>> @@ -284,10 +289,15 @@ static ssize_t __init setup_pcpu_embed(size_t static_size)
>>  	pr_info("PERCPU: Embedded %zu pages at %p, static data %zu bytes\n",
>>  		pcpue_unit_size >> PAGE_SHIFT, pcpue_ptr, static_size);
>>  
>> +#if 0
>>  	return pcpu_setup_first_chunk(pcpue_get_page, static_size,
>>  				      pcpue_unit_size,
>>  				      pcpue_unit_size - static_size, pcpue_ptr,
>>  				      NULL);
>> +#else
>> +	return pcpu_setup_first_chunk(pcpue_get_page, static_size,
>> +				      0, 0, NULL, embed_populate_pte);
>> +#endif
>>  }
> 
> That isn't quite correct but is still very interesting that it fixes
> the build issue.  Super weird.  I'm almost done setting up 11.0 system.
> I'll dig into it as soon as I'm done with sata_nv -stable issue.

Hmm... on my openSUSE 11.0 it builds just fine.

  $ gcc --version
  gcc (SUSE Linux) 4.3.1 20080507 (prerelease) [gcc-4_3-branch revision 135036]
  Copyright (C) 2008 Free Software Foundation, Inc.
  This is free software; see the source for copying conditions.  There is NO
  warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

  $ ld --version
  GNU ld (GNU Binutils; openSUSE 11.0) 2.18.50.20080409-11.1
  Copyright 2007 Free Software Foundation, Inc.
  This program is free software; you may redistribute it under the terms of
  the GNU General Public License version 3 or (at your option) a later version.
  This program has absolutely no warranty.

I've used the config file you attached and the commit ID I used is
d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.

I wonder what is going on.  I'll try again with
89c9215165ca609096e845926d9a18f1306176a4.  Argh... weird.

Thanks.

--
tejun