public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Justin Mattock <justinmattock@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C 	library confusion.
Date: Thu, 05 Mar 2009 07:33:43 -0800	[thread overview]
Message-ID: <49AFF0D7.8080007@oracle.com> (raw)
In-Reply-To: <dd18b0c30903050049g68073bcamce13b9a2605372ba@mail.gmail.com>

> From: Justin P. Mattock <justinmattock@gmail.com>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> 
> This fixes an error when compiling the kernel.

Did you determine why you need this now and other people don't
need it (yet)?  Maybe the rest of us will need it in the future...


>  CHK     include/linux/version.h
>  HOSTCC  scripts/unifdef
> scripts/unifdef.c:209: error: conflicting types for 'getline'
> /usr/include/stdio.h:651: note: previous declaration of 'getline' was here
> make[1]: *** [scripts/unifdef] Error 1
> make: *** [__headers] Error 2
> 
> --
> scripts/unifdef.c  |  3 +++
> 1 files changed, 3 insertions(+),0 deletions(-)
> 
> ---a/scripts/unifdef.c	        2009-03-05 00:07:28.000000000 -0800
> +++b/scripts/unifdef.c	2009-03-05 00:04:56.000000000 -0800
> @@ -206,7 +206,7 @@ static void             done(void);
>  static void             error(const char *);
>  static int              findsym(const char *);
>  static void             flushline(bool);
> -static Linetype         getline(void);
> +static Linetype         get_line(void);
>  static Linetype         ifeval(const char **);
>  static void             ignoreoff(void);
>  static void             ignoreon(void);
> @@ -512,7 +512,7 @@ process(void)
> 
>  	for (;;) {
>  		linenum++;
> -		lineval = getline();
> +		lineval = get_line();
>  		trans_table[ifstate[depth]][lineval]();
>  		debug("process %s -> %s depth %d",
>  		    linetype_name[lineval],
> @@ -526,7 +526,7 @@ process(void)
>   * help from skipcomment().
>   */
>  static Linetype
> -getline(void)
> +get_line(void)
>  {
>  	const char *cp;
>  	int cursym;
> 
> 


-- 
~Randy

  parent reply	other threads:[~2009-03-05 15:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05  5:41 [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion Justin Mattock
2009-03-05  6:04 ` Frederic Weisbecker
2009-03-05  7:51   ` Justin Mattock
2009-03-05  8:46     ` Justin Mattock
2009-03-05  8:49       ` Justin Mattock
2009-03-05  8:57         ` Américo Wang
2009-03-05 15:33         ` Randy Dunlap [this message]
2009-03-05 17:42           ` Justin Mattock
2009-03-05  9:00       ` Frederic Weisbecker
2009-03-05 14:48         ` Justin Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AFF0D7.8080007@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox