From: Li Zefan <lizf@cn.fujitsu.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Rientjes <rientjes@google.com>, Ingo Molnar <mingo@elte.hu>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] lockdep: initialize lockdep debugging statistics
Date: Fri, 06 Mar 2009 18:05:45 +0800 [thread overview]
Message-ID: <49B0F579.2030903@cn.fujitsu.com> (raw)
In-Reply-To: <1236328083.5187.1213.camel@laptop>
Peter Zijlstra wrote:
> On Thu, 2009-03-05 at 13:57 -0800, David Rientjes wrote:
>> It shouldn't be dropped, the initialization is necessary because we can't
>> rely on atomic_t's implementation.
>
> I'm a bit slow, please use more words and explain this to me.
>
I once was also (and is still not sure) wondering if it's better to use
INIT_HLIST_HEAD() for initialization for the reason David is claiming..
The situation is similar with this ATOMIC_INIT(), that INIT_HLIST_HEAD()
just set 2 pointers to 0, and not every user of hlist calls this INIT()
at initialization phase.
But I'll definitely on David's side if it's not kernel project.
> Before replying please read:
>
> ea435467500612636f8f4fb639ff6e76b2496e4b
>
> and stare at the output of:
>
> git grep "define[ \t]*ATOMIC_INIT\>"
>
next prev parent reply other threads:[~2009-03-06 10:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 10:29 [patch 1/2] lockdep: remove duplicate CONFIG_DEBUG_LOCKDEP definitions David Rientjes
2009-03-05 10:29 ` [patch 2/2] lockdep: initialize lockdep debugging statistics David Rientjes
2009-03-05 10:48 ` [tip:core/locking] " David Rientjes
2009-03-05 10:49 ` [patch 2/2] " Peter Zijlstra
2009-03-05 11:05 ` Ingo Molnar
2009-03-05 21:57 ` David Rientjes
2009-03-06 8:28 ` Peter Zijlstra
2009-03-06 9:56 ` David Rientjes
2009-03-06 10:19 ` Peter Zijlstra
2009-03-06 10:27 ` David Rientjes
2009-03-06 10:46 ` Peter Zijlstra
2009-03-06 10:05 ` Li Zefan [this message]
2009-03-05 10:48 ` [tip:core/locking] lockdep: remove duplicate CONFIG_DEBUG_LOCKDEP definitions David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B0F579.2030903@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox