public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
	Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <npiggin@suse.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andi Kleen <andi@firstfloor.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH -tip 3/4]Text Edit Lock - Smp alternatives support
Date: Fri, 06 Mar 2009 10:37:22 -0500	[thread overview]
Message-ID: <49B14332.9030109@redhat.com> (raw)
In-Reply-To: <49B1428A.9050500@redhat.com>

Use the mutual exclusion provided by the text edit lock in alternatives code.
Since alternative_smp_* will be called from module init code, etc,
we'd better protect it from other subsystems.

Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/alternative.c |    5 +++++
 1 file changed, 5 insertions(+)

Index: 2.6.29-rc7/arch/x86/kernel/alternative.c
===================================================================
--- 2.6.29-rc7.orig/arch/x86/kernel/alternative.c
+++ 2.6.29-rc7/arch/x86/kernel/alternative.c
@@ -5,6 +5,7 @@
 #include <linux/kprobes.h>
 #include <linux/mm.h>
 #include <linux/vmalloc.h>
+#include <linux/memory.h>
 #include <asm/alternative.h>
 #include <asm/sections.h>
 #include <asm/pgtable.h>
@@ -226,6 +227,7 @@ static void alternatives_smp_lock(u8 **s
 {
 	u8 **ptr;

+	mutex_lock(&text_mutex);
 	for (ptr = start; ptr < end; ptr++) {
 		if (*ptr < text)
 			continue;
@@ -234,6 +236,7 @@ static void alternatives_smp_lock(u8 **s
 		/* turn DS segment override prefix into lock prefix */
 		text_poke(*ptr, ((unsigned char []){0xf0}), 1);
 	};
+	mutex_unlock(&text_mutex);
 }

 static void alternatives_smp_unlock(u8 **start, u8 **end, u8 *text, u8 *text_end)
@@ -243,6 +246,7 @@ static void alternatives_smp_unlock(u8 *
 	if (noreplace_smp)
 		return;

+	mutex_lock(&text_mutex);
 	for (ptr = start; ptr < end; ptr++) {
 		if (*ptr < text)
 			continue;
@@ -251,6 +255,7 @@ static void alternatives_smp_unlock(u8 *
 		/* turn lock prefix into DS segment override prefix */
 		text_poke(*ptr, ((unsigned char []){0x3E}), 1);
 	};
+	mutex_unlock(&text_mutex);
 }

 struct smp_alt_module {
-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com


  parent reply	other threads:[~2009-03-06 15:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 15:34 [PATCH -tip 0/4] Text edit lock and atomic text_poke() Masami Hiramatsu
2009-03-06 15:35 ` [PATCH -tip 1/4] Text Edit Lock - Architecture Independent Code (v2) Masami Hiramatsu
2009-03-08 15:51   ` [tip:tracing/core] tracing, Text Edit Lock - Architecture Independent Code Mathieu Desnoyers
2009-03-06 15:36 ` [PATCH -tip 2/4]Text Edit Lock - kprobes architecture independent support (v3) Masami Hiramatsu
2009-03-08 15:51   ` [tip:tracing/core] tracing, Text Edit Lock - kprobes architecture independent support Mathieu Desnoyers
2009-03-06 15:37 ` Masami Hiramatsu [this message]
2009-03-06 18:11   ` [PATCH -tip 3/4]Text Edit Lock - Smp alternatives support Mathieu Desnoyers
2009-03-06 18:40     ` Masami Hiramatsu
2009-03-08 15:51   ` [tip:tracing/core] tracing, Text Edit Lock - SMP " Masami Hiramatsu
2009-03-06 15:37 ` [PATCH -tip 4/4] Atomic text_poke() with fixmap Masami Hiramatsu
2009-03-06 18:13   ` Mathieu Desnoyers
2009-03-06 18:18     ` Ingo Molnar
2009-03-06 18:33     ` [PATCH -tip 4/4] Atomic text_poke() with fixmap take2 Masami Hiramatsu
2009-03-06 18:45       ` Mathieu Desnoyers
2009-03-06 19:08       ` Ingo Molnar
2009-03-06 19:15         ` Mathieu Desnoyers
2009-03-06 19:22           ` Ingo Molnar
2009-03-06 20:25             ` [PATCH -tip 5/4] Expands irq-off region in text_poke() Masami Hiramatsu
2009-03-06 21:01               ` Mathieu Desnoyers
2009-03-06 21:57                 ` Masami Hiramatsu
2009-03-07  1:42                   ` Mathieu Desnoyers
2009-03-09 16:40                     ` Masami Hiramatsu
2009-03-10 21:57                       ` [tip:tracing/core] x86: expand " Masami Hiramatsu
2009-03-08 15:51   ` [tip:tracing/core] x86: implement atomic text_poke() via fixmap Masami Hiramatsu
2009-03-06 18:09 ` [PATCH -tip 0/4] Text edit lock and atomic text_poke() Mathieu Desnoyers
2009-03-06 18:12   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B14332.9030109@redhat.com \
    --to=mhiramat@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=arjan@infradead.org \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=npiggin@suse.de \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox