[PATCH] Re: build issue #591 for v2.6.29-rc7-3-g559595a :drivers/staging/mimio/mimio.ko

[Randy Dunlap <randy.dunlap@oracle.com>]

Toralf Förster wrote:
> Hello,
> 
> the build (.config attached) failed, make ends with :
> ...
>   CC      arch/x86/boot/video-bios.o
>   LD      arch/x86/boot/setup.elf
>   OBJCOPY arch/x86/boot/setup.bin
>   OBJCOPY arch/x86/boot/vmlinux.bin
>   HOSTCC  arch/x86/boot/tools/build
>   BUILD   arch/x86/boot/bzImage
> Root device is (3, 8)
> Setup is 22056 bytes (padded to 22528 bytes).
> System is 3078 kB
> CRC b46a0cef
> Kernel: arch/x86/boot/bzImage is ready  (#6)
>   Building modules, stage 2.
>   MODPOST 327 modules
> ERROR: "input_register_device" [drivers/staging/mimio/mimio.ko] undefined!
> ERROR: "input_allocate_device" [drivers/staging/mimio/mimio.ko] undefined!
> ERROR: "input_event" [drivers/staging/mimio/mimio.ko] undefined!
> ERROR: "input_close_device" [drivers/staging/mimio/mimio.ko] undefined!
> ERROR: "input_free_device" [drivers/staging/mimio/mimio.ko] undefined!
> ERROR: "input_unregister_device" [drivers/staging/mimio/mimio.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> The build was made with :
> $>make randconfig; make clean; make
> 
> Here's the config:

[snip]

I posted a patch for this on Feb. 20.
Where is it, Greg?  (yes, you were cc-ed on it)

bah, here it is again.






From: Randy Dunlap <randy.dunlap@oracle.com>

mimio driver uses input_* functions so it needs to depend on INPUT.

mimio.c:(.text+0x2526c9): undefined reference to `input_unregister_device'
mimio.c:(.text+0x2526da): undefined reference to `input_close_device'
mimio.c:(.text+0x252725): undefined reference to `input_free_device'
mimio.c:(.text+0x2528f1): undefined reference to `input_event'
mimio.c:(.text+0x252904): undefined reference to `input_event'
mimio.c:(.text+0x252921): undefined reference to `input_event'
mimio.c:(.text+0x252b3e): undefined reference to `input_event'
mimio.c:(.text+0x252b51): undefined reference to `input_event'
drivers/built-in.o:mimio.c:(.text+0x252bbd): more undefined references to `input_event' follow
mimio.c:(.text+0x252e42): undefined reference to `input_allocate_device'
mimio.c:(.text+0x2530ef): undefined reference to `input_register_device'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: mwilder@cs.nmsu.edu
---
 drivers/staging/mimio/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20090220.orig/drivers/staging/mimio/Kconfig
+++ linux-next-20090220/drivers/staging/mimio/Kconfig
@@ -1,6 +1,6 @@
 config INPUT_MIMIO
 	tristate "Mimio Xi interactive whiteboard support"
-	depends on USB
+	depends on USB && INPUT
 	default N
 	help
 	  Say Y here if you want to use a Mimio Xi interactive