Re: [PATCH] x86: introduce bootmem_state

Jeremy Fitzhardinge
2009-03-06T22:12:21Z

H. Peter Anvin wrote:
> Yinghai Lu wrote:
>
>> Impact: cleanup
>>
>> extend after_bootmem and after_init_bootmem to bootmem_state
>> and will have BEFORE_BOOTMEM, DURING_BOOTMEM, AFTER_BOOTMEM
>>
>>
>
> Wouldn't it make more sense to add these as system_state enumerations
> and use relational comparisons on them (< <= >= >)?

Please, no. system_state should be deprecated; its hard enough to have
a notion of some kind of system-wide state, but putting subsystem
specific substates into it just makes things worse.

J