From: Robert Hancock <hancockrwd@gmail.com>
To: Adrian McMenamin <lkmladrian@gmail.com>
Cc: Roland Dreier <rdreier@cisco.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: printk issue - bug?
Date: Sat, 07 Mar 2009 20:20:19 -0600 [thread overview]
Message-ID: <49B32B63.9030106@gmail.com> (raw)
In-Reply-To: <8b67d60903071704j4392cde7mb826531da079430d@mail.gmail.com>
Adrian McMenamin wrote:
> 2009/3/7 Roland Dreier <rdreier@cisco.com>:
>
>> ie offset is a 64-bit type but the printk format for it is %x, which
>> presumably only consumes 32 bits on SH4? Seems like your code is buggy
>> and you ignored a compiler warning about printk format mismatch?
>>
>> - R.
>>
>
> Yes, loff_t is a long long but why did it work in the first line and
> not the second?
It didn't. You didn't print loff_t in the first printk, and the variable
size mismatch corrupted the next value being printed in the second one.
prev parent reply other threads:[~2009-03-08 2:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 23:37 printk issue - bug? Adrian McMenamin
2009-03-07 23:52 ` Roland Dreier
2009-03-08 1:04 ` Adrian McMenamin
2009-03-08 2:20 ` Robert Hancock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B32B63.9030106@gmail.com \
--to=hancockrwd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmladrian@gmail.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox