Re: [PATCH] x86/pci: try to detect host_bridge pci_cfg_space

Ingo Molnar
2009-03-08T22:28:32Z

* H. Peter Anvin <hpa@zytor.com> wrote:

> Matthew Wilcox wrote:
> > On Sun, Mar 08, 2009 at 02:21:40PM -0700, Yinghai Lu wrote:
> >> Jesse or Matthew, can you pick this patch?
> >
> > Having reviewed it in light of HPA's comment, I don't have a problem
> > with it:
> >
> > Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
> >
> > However, I don't think it's my place to take this patch while Jesse is
> > away; it doesn't feel like it's needed to be submitted between -rc7 and
> > 2.6.29. Do you have a reason that it needs to be merged more urgently
> > than 2.6.30-rc1?
> >
>
> I didn't see one... I was assuming it was a submission to be
> pushed upstream during the merge window.
>
> It doesn't fix a regression, so it doesn't seem to me to be a
> case for a late -rc merge. It's hardware enablement, so it
> *might* qualify for 2.6.29-stable, as far as I understand Greg
> and Chris' policies.

Yeah. The patch is replacing a slowly-but-surely-bitrotting and
always-behind quirk table with a more generic
approach/workaround.

So there's no regression technically - but non-fully-working
cards are obviously quite annoying on new systems. So i'd
suggest a .30 merge with a Cc: <stable@kernel.org> tag.

Ingo