From: Timur Tabi <timur@freescale.com>
To: Will Newton <will.newton@gmail.com>
Cc: linux-kernel@vger.kernel.org, rdreier@cisco.com, jirislaby@gmail.com
Subject: Re: [PATCH v2] add function spin_event_timeout()
Date: Mon, 09 Mar 2009 10:34:12 -0500 [thread overview]
Message-ID: <49B536F4.9060609@freescale.com> (raw)
In-Reply-To: <87a5b0800903090831l6a74b8afhd640ce880be36114@mail.gmail.com>
Will Newton wrote:
> Are you sure you want to evaluate condition a second time when
> returning? Some memory mapped registers don't have a stable value so
> e.g. the first test could succeed but the return value could still be
> zero.
Ah, good point. I was hoping to keep the loop simple by combining the
two test conditions, but I guess that's not going to work.
v3 coming up.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-03-09 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 15:18 [PATCH v2] add function spin_event_timeout() Timur Tabi
2009-03-09 15:31 ` Will Newton
2009-03-09 15:34 ` Timur Tabi [this message]
2009-03-09 16:06 ` Peter Zijlstra
2009-03-09 18:16 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B536F4.9060609@freescale.com \
--to=timur@freescale.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox