Re: [v1 PATCH 1/1] PCI: Add AMD8111 PCI Bridge PCI Device ID

[Harry Ciao <qingtao.cao@windriver.com>]

Hi Greg,

Please see my answers below.


Greg KH 写道:
> On Mon, Mar 09, 2009 at 05:09:03PM +0800, Harry Ciao wrote:
>   
>> Add the PCI Device ID for the PCI Bridge Controller on AMD8111 chip,
>> which is used by AMD8111 EDAC driver.
>>     
>
> Where is the corrisponding change to the edac driver to use this new id?
>
>   
This new id is to be used in the newly added edac driver amd8111_edac.c 
that I have posted to the mailing list on March 9th, it is used to probe 
the PCI Bridge Controller on AMD8111 chip.

> And for ids that are only in one driver, there is no need to add them to
> the pci_ids.h file.  This is what we have been doing for the past few
> years in order to cut down on the merge-mess in the pci_ids.h file for
> no reason.
>
> thanks,
>
> greg k-h
>
>   
Ok, I see for the time being I had better define this new id as a macro 
in amd8111_edac.c.

And I am a little curious that do you mean that pci_ids.h maintainer 
would have to track how many times a new id have been requested to 
decide if to merge it into the file or not?

Thank you very much for your comments!

Best regards,

Harry