[v1 PATCH 0/1] PCI: Add PCI Device ID for the PCI Bridge Controller on AMD8111 chip

[v1 PATCH 0/1] PCI: Add PCI Device ID for the PCI Bridge Controller on AMD8111 chip

[Harry Ciao]

Comments:
---------
Add the PCI Device ID for the PCI Bridge Controller on AMD8111 chip,
which is used by AMD8111 EDAC driver.

Test:
-----
This patch has been tested along with the series of patches of
"[v1 PATCH 0/8] Add AMD8111 and AMD8131 EDAC drivers", the PCI Bridge
Controller on AMD8111 chip could be successfully probed.

Diffstat:
---------
0001-PCI-Add-AMD8111-PCI-Bridge-PCI-Device-ID.patch
 include/linux/pci_ids.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

[v1 PATCH 1/1] PCI: Add AMD8111 PCI Bridge PCI Device ID

[Harry Ciao]

Add the PCI Device ID for the PCI Bridge Controller on AMD8111 chip,
which is used by AMD8111 EDAC driver.

Signed-off-by: Harry Ciao <qingtao.cao@windriver.com>
---
 include/linux/pci_ids.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index aca8c45..15e2ccc 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -526,6 +526,7 @@
 #define PCI_DEVICE_ID_AMD_OPUS_7443	0x7443
 #define PCI_DEVICE_ID_AMD_VIPER_7443	0x7443
 #define PCI_DEVICE_ID_AMD_OPUS_7445	0x7445
+#define PCI_DEVICE_ID_AMD_8111_PCI	0x7460
 #define PCI_DEVICE_ID_AMD_8111_LPC	0x7468
 #define PCI_DEVICE_ID_AMD_8111_IDE	0x7469
 #define PCI_DEVICE_ID_AMD_8111_SMBUS2	0x746a
-- 
1.5.6.2

Re: [v1 PATCH 1/1] PCI: Add AMD8111 PCI Bridge PCI Device ID

[Greg KH]

On Mon, Mar 09, 2009 at 05:09:03PM +0800, Harry Ciao wrote:
> Add the PCI Device ID for the PCI Bridge Controller on AMD8111 chip,
> which is used by AMD8111 EDAC driver.

Where is the corrisponding change to the edac driver to use this new id?

And for ids that are only in one driver, there is no need to add them to
the pci_ids.h file.  This is what we have been doing for the past few
years in order to cut down on the merge-mess in the pci_ids.h file for
no reason.

thanks,

greg k-h

Re: [v1 PATCH 1/1] PCI: Add AMD8111 PCI Bridge PCI Device ID

[Harry Ciao]

Hi Greg,

Please see my answers below.


Greg KH 写道:
> On Mon, Mar 09, 2009 at 05:09:03PM +0800, Harry Ciao wrote:
>   
>> Add the PCI Device ID for the PCI Bridge Controller on AMD8111 chip,
>> which is used by AMD8111 EDAC driver.
>>     
>
> Where is the corrisponding change to the edac driver to use this new id?
>
>   
This new id is to be used in the newly added edac driver amd8111_edac.c 
that I have posted to the mailing list on March 9th, it is used to probe 
the PCI Bridge Controller on AMD8111 chip.

> And for ids that are only in one driver, there is no need to add them to
> the pci_ids.h file.  This is what we have been doing for the past few
> years in order to cut down on the merge-mess in the pci_ids.h file for
> no reason.
>
> thanks,
>
> greg k-h
>
>   
Ok, I see for the time being I had better define this new id as a macro 
in amd8111_edac.c.

And I am a little curious that do you mean that pci_ids.h maintainer 
would have to track how many times a new id have been requested to 
decide if to merge it into the file or not?

Thank you very much for your comments!

Best regards,

Harry

Re: [v1 PATCH 1/1] PCI: Add AMD8111 PCI Bridge PCI Device ID

[Greg KH]

On Tue, Mar 10, 2009 at 09:26:12AM +0800, Harry Ciao wrote:
> Greg KH 写道:
>> On Mon, Mar 09, 2009 at 05:09:03PM +0800, Harry Ciao wrote:
>>   
>>> Add the PCI Device ID for the PCI Bridge Controller on AMD8111 chip,
>>> which is used by AMD8111 EDAC driver.
>>>     
>>
>> Where is the corrisponding change to the edac driver to use this new id?
>>
>>   
> This new id is to be used in the newly added edac driver amd8111_edac.c 
> that I have posted to the mailing list on March 9th, it is used to probe 
> the PCI Bridge Controller on AMD8111 chip.

So that patch depends on this one?  You should just use the device id
within your driver, no need to modify this header file at all.

>> And for ids that are only in one driver, there is no need to add them to
>> the pci_ids.h file.  This is what we have been doing for the past few
>> years in order to cut down on the merge-mess in the pci_ids.h file for
>> no reason.
>>
> Ok, I see for the time being I had better define this new id as a macro in 
> amd8111_edac.c.

Yes, as a permanent solution.

> And I am a little curious that do you mean that pci_ids.h maintainer
> would have to track how many times a new id have been requested to
> decide if to merge it into the file or not?

No, someone would notice it and submit such a patch.

thanks,

greg k-h