From: Jiri Slaby <jirislaby@gmail.com>
To: Breno Leitao <leitao@linux.vnet.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/1] icom: Removing unused variables and converting space to tabs
Date: Wed, 11 Mar 2009 16:26:40 +0100 [thread overview]
Message-ID: <49B7D830.10601@gmail.com> (raw)
In-Reply-To: <49B7D63E.9050006@linux.vnet.ibm.com>
On 11.3.2009 16:18, Breno Leitao wrote:
> --- a/drivers/serial/icom.c
> +++ b/drivers/serial/icom.c
> @@ -1022,7 +1022,6 @@ static void icom_send_xchar(struct uart_port *port, char ch)
> writeb(ch,&ICOM_PORT->dram->xchar);
>
> /* flush write operation */
> - xdata = readb(&ICOM_PORT->dram->xchar);
NACK. Did you read the comment above?
next prev parent reply other threads:[~2009-03-11 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 15:18 [PATCH 1/1] icom: Removing unused variables and converting space to tabs Breno Leitao
2009-03-11 15:26 ` Jiri Slaby [this message]
2009-03-11 19:42 ` [PATCH 1/2] icom: Converting " Breno Leitao
2009-03-11 19:44 ` [PATCH 2/2] icom: Removing unused variables Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B7D830.10601@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=leitao@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox