From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
tony.luck@intel.com, ralf@linux-mips.org, kyle@mcmartin.ca,
schwidefsky@de.ibm.com
Subject: Re: [PATCH] generic compat_sys_ustat
Date: Wed, 11 Mar 2009 14:18:53 -0500 [thread overview]
Message-ID: <49B80E9D.3@sandeen.net> (raw)
In-Reply-To: <20081128090909.GA28299@lst.de>
Christoph Hellwig wrote:
> Due to a different size of ino_t ustat needs a compat handler, but
> currently only x86 and mips provide one. Add a generic compat_sys_ustat
> and switch all architectures over to it. Instead of doing various
> user copy hacks compat_sys_ustat just reimplements sys_ustat as
> it's trivial. This was suggested by Arnd Bergmann.
>
> Found by Eric Sandeen when running xfstests/017 on ppc64, which causes
> stack smashing warnings on RHEL/Fedora due to the too large amount of
> data writen by the syscall.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks like this got lost?
-Eric
>
> Index: linux-2.6/arch/x86/ia32/ia32entry.S
> ===================================================================
> --- linux-2.6.orig/arch/x86/ia32/ia32entry.S 2008-11-28 14:09:01.000000000 +0530
> +++ linux-2.6/arch/x86/ia32/ia32entry.S 2008-11-28 14:09:16.000000000 +0530
> @@ -555,7 +555,7 @@ ia32_sys_call_table:
> .quad sys32_olduname
> .quad sys_umask /* 60 */
> .quad sys_chroot
> - .quad sys32_ustat
> + .quad compat_sys_ustat
> .quad sys_dup2
> .quad sys_getppid
> .quad sys_getpgrp /* 65 */
....
next prev parent reply other threads:[~2009-03-11 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 8:41 [PATCH] generic compat_sys_ustat Christoph Hellwig
2008-11-21 9:01 ` Ralf Baechle
2008-11-21 15:10 ` Eric Sandeen
2008-11-21 17:38 ` Eric Sandeen
2008-11-24 20:47 ` Eric Sandeen
2008-11-25 17:01 ` Kyle McMartin
2008-11-26 12:40 ` Christoph Hellwig
2008-11-26 13:17 ` Arnd Bergmann
2008-11-28 9:09 ` Christoph Hellwig
2009-03-11 19:18 ` Eric Sandeen [this message]
2009-03-14 12:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B80E9D.3@sandeen.net \
--to=sandeen@sandeen.net \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox