From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755953AbZCLCtG (ORCPT ); Wed, 11 Mar 2009 22:49:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754158AbZCLCsy (ORCPT ); Wed, 11 Mar 2009 22:48:54 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:50807 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751511AbZCLCsy (ORCPT ); Wed, 11 Mar 2009 22:48:54 -0400 Message-ID: <49B8781C.3050609@cn.fujitsu.com> Date: Thu, 12 Mar 2009 10:49:00 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Paul Menage CC: Andrew Morton , LKML , Linux Containers Subject: Re: [PATCH] debug cgroup: remove unneeded cgroup_lock References: <49B869B7.1090108@cn.fujitsu.com> <6599ad830903111943u2799333dh680470f9daa6ccbb@mail.gmail.com> In-Reply-To: <6599ad830903111943u2799333dh680470f9daa6ccbb@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Menage wrote: > On Wed, Mar 11, 2009 at 6:47 PM, Li Zefan wrote: >> Since we are in cgroup write handler, so the cgrp is valid, so we >> don't have to hold cgroup_mutex when calling cgroup_task_count(). >> One similar example is in cgroup_tasks_open(). >> >> Signed-off-by: Li Zefan > > Acked-by: Paul Menage > > (Although this conflicts with a patch that I'm about to send out that > moves the code from cgroup_debug.c into cgroup.c to allow internal > details to be reported in the debug.* files.) > or let cgroup.c #include ?