From: "Jan Beulich" <jbeulich@novell.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: clean up output resulting from update_mptable option
Date: Thu, 12 Mar 2009 12:57:10 +0000 [thread overview]
Message-ID: <49B914B6.76E4.0078.0@novell.com> (raw)
Impact: cleanup
Without apic=verbose, using the update_mptable option would result in
garbled and confusing output due to the inconsistent use of printk() vs
apic_printk().
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/kernel/mpparse.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.29-rc7/arch/x86/kernel/mpparse.c 2009-03-04 09:10:19.000000000 +0100
+++ 2.6.29-rc7-x86-update-mptable/arch/x86/kernel/mpparse.c 2009-03-06 11:07:34.000000000 +0100
@@ -876,12 +876,12 @@ static int __init replace_intsrc_all(st
#ifdef CONFIG_X86_IO_APIC
struct mpc_intsrc *m = (struct mpc_intsrc *)mpt;
- printk(KERN_INFO "OLD ");
+ apic_printk(APIC_VERBOSE, "OLD ");
print_MP_intsrc_info(m);
i = get_MP_intsrc_index(m);
if (i > 0) {
assign_to_mpc_intsrc(&mp_irqs[i], m);
- printk(KERN_INFO "NEW ");
+ apic_printk(APIC_VERBOSE, "NEW ");
print_mp_irq_info(&mp_irqs[i]);
} else if (!i) {
/* legacy, do nothing */
@@ -929,7 +929,7 @@ static int __init replace_intsrc_all(st
continue;
if (nr_m_spare > 0) {
- printk(KERN_INFO "*NEW* found ");
+ apic_printk(APIC_VERBOSE, "*NEW* found\n");
nr_m_spare--;
assign_to_mpc_intsrc(&mp_irqs[i], m_spare[nr_m_spare]);
m_spare[nr_m_spare] = NULL;
next reply other threads:[~2009-03-12 12:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 12:57 Jan Beulich [this message]
2009-03-13 2:34 ` [tip:x86/mm] x86: clean up output resulting from update_mptable option Jan Beulich
2009-03-13 4:35 ` [PATCH] x86: fix e820_update_range() Yinghai Lu
2009-03-13 4:39 ` [tip:x86/mm] " Yinghai Lu
2009-03-13 5:36 ` [PATCH] x86: make e820_update_range to handle small range update Yinghai Lu
2009-03-14 11:39 ` [tip:x86/mm] x86: make e820_update_range() " Yinghai Lu
2009-03-14 12:17 ` Ingo Molnar
2009-03-14 18:21 ` Yinghai Lu
2009-03-14 18:40 ` Ingo Molnar
2009-03-14 21:32 ` Yinghai Lu
2009-03-15 6:04 ` Ingo Molnar
2009-03-15 6:20 ` Yinghai Lu
2009-03-15 6:25 ` Ingo Molnar
2009-03-15 6:12 ` [tip:x86/mm] x86: fix 64k corruption-check Yinghai Lu
2009-03-13 7:57 ` [PATCH] x86: fix e820_update_range() Jan Beulich
2009-03-13 11:13 ` Ingo Molnar
2009-03-13 18:22 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B914B6.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox