From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: Ingo Molnar <mingo@elte.hu>,
jeremy.fitzhardinge@citrix.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86-64: fix HYPERVISOR_update_descriptor()
Date: Thu, 12 Mar 2009 08:02:01 -0700 [thread overview]
Message-ID: <49B923E9.6020603@zytor.com> (raw)
In-Reply-To: <49B9056F.76E4.0078.0@novell.com>
Jan Beulich wrote:
>> See:
>>
>> http://lkml.org/lkml/2008/10/28/67
>
> Thanks. Would certainly be helpful to put into Documentation/ if this is
> meant to be more than just a personal requirement of yours.
It's something we started with in the x86 tree (it came out of a long
discussion Ingo and I had about how to filter patches.) It's not like
we can impose this workflow on others, but it has been *way* useful: a
patch with a *meaningful* "Impact:" line typically needs less than a
third of the human time than one without -- simply because it forces the
submitter to think about it.
Similarly "Fix foo" is not a complete description in any way. Why was
foo broken in the first place?
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-03-12 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 10:36 [PATCH] x86-64: fix HYPERVISOR_update_descriptor() Jan Beulich
2009-03-12 10:54 ` Ingo Molnar
2009-03-12 11:25 ` Jan Beulich
2009-03-12 11:35 ` Ingo Molnar
2009-03-12 11:51 ` Jan Beulich
2009-03-12 15:02 ` H. Peter Anvin [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-16 11:37 Jan Beulich
2008-12-16 17:55 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B923E9.6020603@zytor.com \
--to=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox