From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757062AbZCLPCd (ORCPT ); Thu, 12 Mar 2009 11:02:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754214AbZCLPCW (ORCPT ); Thu, 12 Mar 2009 11:02:22 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43656 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756792AbZCLPCW (ORCPT ); Thu, 12 Mar 2009 11:02:22 -0400 Message-ID: <49B923E9.6020603@zytor.com> Date: Thu, 12 Mar 2009 08:02:01 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Jan Beulich CC: Ingo Molnar , jeremy.fitzhardinge@citrix.com, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86-64: fix HYPERVISOR_update_descriptor() References: <49B8F3D4.76E4.0078.0@novell.com> <20090312105426.GC30204@elte.hu> <49B8FF3E.76E4.0078.0@novell.com> <20090312113520.GA8353@elte.hu> <49B9056F.76E4.0078.0@novell.com> In-Reply-To: <49B9056F.76E4.0078.0@novell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jan Beulich wrote: >> See: >> >> http://lkml.org/lkml/2008/10/28/67 > > Thanks. Would certainly be helpful to put into Documentation/ if this is > meant to be more than just a personal requirement of yours. It's something we started with in the x86 tree (it came out of a long discussion Ingo and I had about how to filter patches.) It's not like we can impose this workflow on others, but it has been *way* useful: a patch with a *meaningful* "Impact:" line typically needs less than a third of the human time than one without -- simply because it forces the submitter to think about it. Similarly "Fix foo" is not a complete description in any way. Why was foo broken in the first place? -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.