Re: [PATCH V3] kallsyms, tracing: output more proper symbol name

[Paulo Marques <pmarques@grupopie.com>]

Andrew Morton wrote:
> On Fri, 13 Mar 2009 20:40:13 +0100
> Sam Ravnborg <sam@ravnborg.org> wrote:
> 
>>> This patch puts symbols like "__irqentry_text_start" to the second
>>> aliased symbols. And a more proper symbol name becomes the first.
>>>
>>> Aliased symbols mostly come from linker script. The solution is
>>> guessing "is this symbol defined in linker script", the symbols
>>> defined in linker script will not become the first aliased symbol.
>>>
>>> And if symbols are found to be equal in this "linker script provided"
>>> criteria, symbols are sorted by the number of prefix underscores.
>>>
>>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>> Looks good to me.
>>
>> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> So... do we need this in 2.6.29?

IMHO, no. I think the way the kernel handles aliased symbols hasn't
changed in a very long time so one more release shouldn't make a big
difference.

Even if the risk of the patch breaking something is small, taking that
chance for such a small gain this late in the 2.6.29 cycle is just not
worth it.

-- 
Paulo Marques - www.grupopie.com

"You're just jealous because the voices only talk to me."