From: "H. Peter Anvin" <hpa@zytor.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: relocs is only used with 32bit
Date: Fri, 13 Mar 2009 16:31:50 -0700 [thread overview]
Message-ID: <49BAECE6.7060009@zytor.com> (raw)
In-Reply-To: <m1mybpt5t8.fsf@fess.ebiederm.org>
Eric W. Biederman wrote:
>>
>> In general I prefer minimizing the conditional sections rather than
>> maximizing them. If nothing else, it catches errors earlier that way,
>> and makes it easier to eventually eliminate them entirely.
>
> Makes sense. Although in this case that rule appears like it
> can't even execute on x86_64.
>
That's fine. This is the same reason why it's better to have
if () { ... } than #ifdef as long as the condition can be statically
determined -- at least this way make will complain about a syntax error.
-hpa
prev parent reply other threads:[~2009-03-13 23:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 19:22 [PATCH] x86: relocs is only used with 32bit Yinghai Lu
2009-03-12 4:28 ` H. Peter Anvin
2009-03-13 22:29 ` Eric W. Biederman
2009-03-13 23:31 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BAECE6.7060009@zytor.com \
--to=hpa@zytor.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox