Re: [PATCH] x86: print out in e820_update_range()

Ingo Molnar
2009-03-15T18:55:51Z

* Yinghai Lu <yinghai@kernel.org> wrote:

> Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@kernel.org> wrote:
> >
> >> Impact: to find crazy calling
> >>
> >> try to print out more info, to catch wrong calling
> >
> > Could we detect incorrect parameters more directly as well, via
> > a check and a panic()?
>
> only valid checking seems to be
> virt_to_phys(_text), virt_to_phys(_end)
>
>
> if (new_type == E820_RESERVED && start >= virt_to_phys(_text) && start <= virt_to_phys(_end))
> panic("try to update to e820 range for kernel to RESERVED!");

hm, seems a bit too specialized.

Ingo