From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm/x86: check KVM_REQ_TLB_FLUSH with irqs disabled
Date: Mon, 16 Mar 2009 20:32:42 +0200 [thread overview]
Message-ID: <49BE9B4A.5040106@redhat.com> (raw)
In-Reply-To: <20090316183000.GC3783@amt.cnet>
Marcelo Tosatti wrote:
> BTW, I've wondered if the local_irq_enable in svm_vcpu_run is safe:
>
> clgi();
>
> local_irq_enable();
>
> There is no way that an interrupt can be handled there without an exit,
> right?
>
clgi trumps sti, so all interrupts will be deferred until the guest is
entered (which will cause an immediate vmexit).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-03-16 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 13:03 [PATCH] kvm/x86: check KVM_REQ_TLB_FLUSH with irqs disabled Joerg Roedel
2009-03-16 13:12 ` Avi Kivity
2009-03-16 14:11 ` Joerg Roedel
2009-03-16 18:30 ` Marcelo Tosatti
2009-03-16 18:32 ` Avi Kivity [this message]
2009-03-16 18:44 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BE9B4A.5040106@redhat.com \
--to=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox