public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: {PATCH] x86: print out initial max_pfn_mapped
Date: Mon, 16 Mar 2009 19:36:17 -0700	[thread overview]
Message-ID: <49BF0CA1.3010304@zytor.com> (raw)
In-Reply-To: <49BF0978.40605@kernel.org>

Yinghai Lu wrote:
> Impact: more debug info
> 
> check range that is mapped before init_memory_mapping().
> also make 64bit have max_pfn_mapped assigned before that calling
> 
> Index: linux-2.6/arch/x86/mm/init.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/mm/init.c
> +++ linux-2.6/arch/x86/mm/init.c
> @@ -65,12 +65,11 @@ static void __init find_early_table_spac
>  	 */
>  #ifdef CONFIG_X86_32
>  	start = 0x7000;
> -	e820_table_start = find_e820_area(start, max_pfn_mapped<<PAGE_SHIFT,
> -					tables, PAGE_SIZE);
> -#else /* CONFIG_X86_64 */
> +#else
>  	start = 0x8000;
> -	e820_table_start = find_e820_area(start, end, tables, PAGE_SIZE);
>  #endif
> +	e820_table_start = find_e820_area(start, max_pfn_mapped<<PAGE_SHIFT,
> +					tables, PAGE_SIZE);
>  	if (e820_table_start == -1UL)
>  		panic("Cannot find space for the kernel page tables");
>  

This doesn't seem to match anything anywhere in the description.
Furthermore, why do we even have a different starting address for
different architectures?  If anything, this starting address is way too
low (hogging ZONE_DMA and all that...)

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


  reply	other threads:[~2009-03-17  2:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-17  2:22 {PATCH] x86: print out initial max_pfn_mapped Yinghai Lu
2009-03-17  2:36 ` H. Peter Anvin [this message]
2009-03-17  3:30   ` Yinghai Lu
2009-05-11  9:53 ` [tip:x86/mm] x86: clean up and and " tip-bot for Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BF0CA1.3010304@zytor.com \
    --to=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox