From: Frank Rowand <frank.rowand@am.sony.com>
To: mingo@redhat.com
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: [patch] one extra (incorrect) test in mask_ack_irq()
Date: Wed, 18 Mar 2009 19:16:46 -0700 [thread overview]
Message-ID: <49C1AB0E.5060800@am.sony.com> (raw)
preempt-irqs-core.patch added an incorrect check for the existence of
desc->chip->ack to mask_ack_irq()
Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
--- linux-2.6.29-rc7/kernel/irq/chip.c 2009-03-18 17:58:03.000000000 -0800
+++ linux-2.6.29-rc7_new/kernel/irq/chip.c 2009-03-18 17:59:15.000000000 -0800
@@ -293,7 +293,6 @@ static inline void mask_ack_irq(struct i
if (desc->chip->mask_ack)
desc->chip->mask_ack(irq);
else {
- if (desc->chip->ack)
if (desc->chip->mask)
desc->chip->mask(irq);
if (desc->chip->ack)
next reply other threads:[~2009-03-19 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 2:16 Frank Rowand [this message]
2009-03-19 7:32 ` [patch] one extra (incorrect) test in mask_ack_irq() Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C1AB0E.5060800@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox