public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk
Date: Fri, 20 Mar 2009 09:49:48 +0800	[thread overview]
Message-ID: <49C2F63C.2090107@cn.fujitsu.com> (raw)
In-Reply-To: <49C2F599.3060306@cn.fujitsu.com>

bdev->bd_disk can be NULL, if the block device is not opened.

Try this against an unmounted partition, and you'll see NULL dereference:
  # echo 1 > /sys/block/sda/sda5/enable

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/trace/blktrace.c |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 46e0cfe..37095d9 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -1362,6 +1362,14 @@ static int blk_str2act_mask(const char *str)
 	return mask;
 }
 
+static request_queue *blk_trace_get_queue(struct block_device *bdev)
+{
+	if (bdev->bd_disk == NULL)
+		return NULL;
+
+	return bdev_get_queue(bdev);
+}
+
 static ssize_t sysfs_blk_trace_attr_show(struct device *dev,
 					 struct device_attribute *attr,
 					 char *buf)
@@ -1376,9 +1384,10 @@ static ssize_t sysfs_blk_trace_attr_show(struct device *dev,
 	if (bdev == NULL)
 		goto out_unlock_kernel;
 
-	q = bdev_get_queue(bdev);
+	q = blk_trace_get_queue(bdev);
 	if (q == NULL)
 		goto out_bdput;
+
 	mutex_lock(&bdev->bd_mutex);
 
 	if (attr == &dev_attr_enable) {
@@ -1435,7 +1444,7 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
 	if (bdev == NULL)
 		goto out_unlock_kernel;
 
-	q = bdev_get_queue(bdev);
+	q = blk_trace_get_queue(bdev);
 	if (q == NULL)
 		goto out_bdput;
 
-- 
1.5.4.rc3


  parent reply	other threads:[~2009-03-20  1:49 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20  1:47 [PATCH 0/7] blktrace: various cleanups and fixes Li Zefan
2009-03-20  1:47 ` [PATCH 1/7] blktrace: fix possible memory leak Li Zefan
2009-03-20 10:25   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 12:53   ` [PATCH 1/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:48 ` [PATCH 2/7] blktrace: make blk_tracer_enabled a bool flag Li Zefan
2009-03-20  8:47   ` Frederic Weisbecker
2009-03-20 10:26   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 12:58   ` [PATCH 2/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:48 ` [PATCH 3/7] blktrace: remove blk_probe_mutex Li Zefan
2009-03-20  8:50   ` Frederic Weisbecker
2009-03-20 10:26   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:03   ` [PATCH 3/7] " Arnaldo Carvalho de Melo
2009-03-22  6:04     ` Li Zefan
2009-03-22 15:09       ` Arnaldo Carvalho de Melo
2009-03-21 15:18   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:48 ` [PATCH 4/7] blktrace: don't increase blk_probes_ref if failed to setup blk trace Li Zefan
2009-03-20 10:26   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:04   ` [PATCH 4/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:49 ` [PATCH 5/7] blktrace: report EBUSY correctly Li Zefan
2009-03-20 10:26   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:10   ` [PATCH 5/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18     ` Ingo Molnar
2009-03-21 15:19   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:49 ` [PATCH 6/7] blktrace: remove sysfs_blk_trace_enable_show/store() Li Zefan
2009-03-20  3:33   ` Li Zefan
2009-03-20 10:26     ` [tip:tracing/blktrace] " Li Zefan
2009-03-21 15:19     ` Li Zefan
2009-03-20 13:07   ` [PATCH 6/7] " Arnaldo Carvalho de Melo
2009-03-20  1:49 ` Li Zefan [this message]
2009-03-20  2:34   ` [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk Li Zefan
2009-03-20 10:26     ` [tip:tracing/blktrace] " Li Zefan
2009-03-21 15:19     ` Li Zefan
2009-03-20 13:08   ` [PATCH 7/7] " Arnaldo Carvalho de Melo
2009-03-20 10:20 ` [PATCH 0/7] blktrace: various cleanups and fixes Ingo Molnar
2009-03-20 11:09   ` Ingo Molnar
2009-03-23 14:48     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C2F63C.2090107@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox