public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org, bzolnier@gmail.com
Cc: "Jörg Dorchain" <joerg@dorchain.net>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Tim Waugh" <tim@cyberelk.net>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>,
	"Paul Mackerras" <paulus@samba.org>,
	"Jeremy Fitzhardinge" <jeremy@xensource.com>,
	"Grant Likely" <grant.likely@secretlab.ca>,
	"Markus Lidel" <Markus.Lidel@shadowconnect.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Pete Zaitcev" <zaitcev@redhat.com>
Subject: Re: [PATCH 15/17] block: kill end_request()
Date: Sat, 21 Mar 2009 11:58:11 +0900	[thread overview]
Message-ID: <49C457C3.6080909@kernel.org> (raw)
In-Reply-To: <1237170540-19130-16-git-send-email-tj@kernel.org>

Tejun Heo wrote:
> Impact: kill obsolete interface function
> 
> end_request() has been kept around for backward compatibility;
> however, it seems to be about time for it to go away.
> 
> * There aren't too many users left.
> 
> * Its use of @updtodate is pretty confusing.
> 
> * In some cases, newer code ends up using mixture of end_request() and
>   [__]blk_end_request[_all](), which is way too confusing.
> 
> So, kill it.
> 
> Most conversions are straightforward.  Noteworthy ones are...
> 
> * paride/pcd: next_request() updated to take 0/-errno instead of 1/0.
> 
> * paride/pf: pf_end_request() and next_request() updated to take
>   0/-errno instead of 1/0.
> 
> * xd: xd_readwrite() updated to return 0/-errno instead of 1/0.
> 
> * mtd/mtd_blkdevs: blktrans_discard_request() updated to return
>   0/-errno instead of 1/0.  Unnecessary local variable res
>   initialization removed from mtd_blktrans_thread().

This patch isn't correct.  Will post updated version later.

Thanks.

-- 
tejun

  parent reply	other threads:[~2009-03-21  3:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16  2:28 [GIT PATCH] block: cleanup patches, take#2 Tejun Heo
2009-03-16  2:28 ` [PATCH 01/17] ide: use blk_run_queue() instead of blk_start_queueing() Tejun Heo
2009-03-16  2:28 ` [PATCH 02/17] ide: don't set REQ_SOFTBARRIER Tejun Heo
2009-03-16  2:28 ` [PATCH 03/17] ide: use blk_update_request() instead of blk_end_request_callback() Tejun Heo
2009-03-16  2:28 ` [PATCH 04/17] block: merge blk_invoke_request_fn() into __blk_run_queue() Tejun Heo
2009-03-16  2:28 ` [PATCH 05/17] block: kill blk_start_queueing() Tejun Heo
2009-03-16  2:28 ` [PATCH 06/17] block: don't set REQ_NOMERGE unnecessarily Tejun Heo
2009-03-16  2:28 ` [PATCH 07/17] block: cleanup REQ_SOFTBARRIER usages Tejun Heo
2009-03-16  2:28 ` [PATCH 08/17] block: clean up misc stuff after block layer timeout conversion Tejun Heo
2009-03-16  2:28 ` [PATCH 09/17] block: reorder request completion functions Tejun Heo
2009-03-16  2:28 ` [PATCH 10/17] block: reorganize request fetching functions Tejun Heo
2009-03-16  2:28 ` [PATCH 11/17] block: kill blk_end_request_callback() Tejun Heo
2009-03-16  2:28 ` [PATCH 12/17] block: clean up request completion API Tejun Heo
2009-03-16  2:28 ` [PATCH 13/17] block: move rq->start_time initialization to blk_rq_init() Tejun Heo
2009-03-16  2:28 ` [PATCH 14/17] block: implement and use [__]blk_end_request_all() Tejun Heo
2009-03-16  2:28 ` [PATCH 15/17] block: kill end_request() Tejun Heo
2009-03-16  3:23   ` Grant Likely
2009-03-16  3:27     ` Grant Likely
2009-03-21  2:58   ` Tejun Heo [this message]
2009-03-24 11:37     ` Jens Axboe
2009-03-24 13:07       ` Tejun Heo
2009-03-16  2:28 ` [PATCH 16/17] ubd: simplify block request completion Tejun Heo
2009-03-16  2:29 ` [PATCH 17/17] block: clean up unnecessary stuff from block drivers Tejun Heo
2009-03-16 17:53 ` [GIT PATCH] block: cleanup patches, take#2 Bartlomiej Zolnierkiewicz
2009-03-17  0:10   ` Tejun Heo
2009-03-18 17:17     ` Bartlomiej Zolnierkiewicz
2009-03-19  0:19       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C457C3.6080909@kernel.org \
    --to=tj@kernel.org \
    --cc=Markus.Lidel@shadowconnect.com \
    --cc=axboe@kernel.dk \
    --cc=bzolnier@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jeremy@xensource.com \
    --cc=joerg@dorchain.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tim@cyberelk.net \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox